[feature] improve options type #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY is this change introduced?
SearchOptionstype has been updated.searchTextandsearchItemsno longer have default values.search(Partial<SearchOptions>)parameter is no longer a Partial typeResolves #73
WHAT does this PR introduce or fix?
Generic type support has been added.
QA Checklist
README.mdand related documentation, if necessaryDependency-specific Checklist
No dependency has been added
Usage-specific Checklist
Release Notes
Note: once this PR is merged, a new release or update might be required for the users.
searchfunction now takes an optional generic type.