Pydantic foundations #153
Open
Pydantic foundations #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change master to leader. * Updated master to leader. * Complete rewrite of library and parser. * Example sender and receiver. * Changed master to leader. * Updated documentation with new header format. * Removed section about RTP (for now). * Updated based on feedback from Steve R. * Removed residual reference to parentId. --------- Co-authored-by: Marcus Bengtsson <[email protected]>
…antic won't allow that.
…ere we were passing in a list instead of a tuple.
…h multicomponent snake_case field names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements
camdkiton Pydantic foundations.There are no more manually implemented
validate(),to_json(),from_json()or evenmake_json_schema()methods.The fundamental aggregating construct is the Pydantic
BaseModelon whichCompatibleBaseModelis built.Changes in client code have been avoided wherever possible. There are a few things:
validate()on it can't be implemented.TimecodeFormat. In the Pydantic implementation, callers will need to replacewith
No attempt has been made to Pydanticize any of
opentrackio_lib.py,open.trackio_parser.py,opentrackio_receiver.pyoropentrackio_sender.py. Personally I think in an ideal world we would have a Pydanticized parser and also a C++ implementation -- probably C++14 to make Steve's RHEL8 platforms happy -- and would test round-tripping starting at either end. But that's not touched on by this PR.I am not sure why GitHub is telling me that this can't be automatically merged, but if someone wants to explain to me what I would need to do to remedy that I'd certainly be open to the idea. Right now I just want to get eyes on this.