Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C14 extension #1214

Merged
merged 43 commits into from
Feb 6, 2025
Merged

C14 extension #1214

merged 43 commits into from
Feb 6, 2025

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 24, 2025

Pull Request

This PR is for a

For the following list(s):

  • ancientmetagenome-environmental (README)
  • ancientmetagenome-hostassociated (README)
  • ancientsinglegenome-hostassociated (README)

This is to close

PR Workflow

  1. Open this PR with sample metadata on the samples metadata sheet (:tada: you're already here!)
  2. Wait for checks for sample metdata to pass
  3. (If checks fail) make corrections, and push changes to this branch (no need to open a new PR!)
  4. (Once passed) comment on this PR @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! (may take a minute or so to get the comment with the file)
  5. Fill in the template, and verify autofilled data correct!
  6. Once filled in, append(!) the new rows from the TEMPLATE file to the end of the corresponding library metadata file, and update this PR
  7. Wait for checks for library metadata to pass
  8. Request review!

Pre-review checklist (new publications)

  • Publication is published
    • Preprints currently not accepted?
  • Checked the publication is not already in the database?
  • Checked samples in this publication are not previously published data?
    • Newly re-sequenced metagenomes are OK!
  • Samples are shotgun metagenomes and not amplicon data
    • Note: hostassociated-singlegenome may also contain whole-genome enriched data
  • Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
  • Once sample table validation completed Library metadata has been added
    • Use @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! May take a minute or so to get the comment with the file
    • Fill in template, and verify autofill data correct!
    • Once filled in, append(!) the new rows to the end of the corresponding library metadata file
  • Changelog is updated to include the publication under 'Added'?

@aidaanva aidaanva marked this pull request as ready for review January 27, 2025 12:07
@aidaanva aidaanva requested review from alexhbnr and removed request for alexhbnr January 27, 2025 12:08
@aidaanva aidaanva marked this pull request as draft January 27, 2025 12:27
@aidaanva aidaanva marked this pull request as ready for review January 30, 2025 07:43
@aidaanva aidaanva requested a review from KaHea-21 January 31, 2025 17:02
@aidaanva
Copy link
Member

@KaHea-21 I think the documentation for the radiocarbon part is more or less complete

"title": "Sample Material Used For Dating",
"$ref": "https://spaam-community.github.io/AncientMetagenomeDir/assets/enums/material.json",
"description": "Sample material used for extraction of e.g. collagen for generating the radiocarbon date",
"examples": ["bone", "enamel"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"examples": ["bone", "enamel"]
"examples": ["bone", "enamel", "wood"]

@maxibor
Copy link
Collaborator

maxibor commented Feb 4, 2025

Hey @aidaanva @jfy133 @KaHea-21 ,
Unless there are any code changes to review, I'll leave you this PR 🙂

@maxibor maxibor removed their request for review February 4, 2025 09:23
…ostassociated_dates_schema.json

Co-authored-by: KaHea-21 <[email protected]>
Copy link
Collaborator

@alexhbnr alexhbnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The README could be slightly improved by language editing and standardising the capitalisation of words but this is cosmetics. Great job, well done! @aidaanva @KaHea-21 @jfy133

Copy link

github-actions bot commented Feb 6, 2025

amdirt, version 1.6.5

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

Dates

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_dates.tsv is valid

@aidaanva aidaanva merged commit 6b8d05b into master Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants