Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Stop loading external resources (#311) #312

Merged
merged 1 commit into from
Oct 24, 2024
Merged

refactor: Stop loading external resources (#311) #312

merged 1 commit into from
Oct 24, 2024

Conversation

Zalaras
Copy link
Contributor

@Zalaras Zalaras commented Oct 23, 2024 •
edited by richardwooding
Loading

  • Update jQuery to 3.6 to match what's being loaded from code.jquery.com
  • Add boostrap.min.css that's being loaded externally
  • Move glyphicons to the path bootstrap expects
  • Stop loading scripts/CSS from external CDN domains
  • Fix invalid href on presidium-enterprise.js
  • chore: update changelog
  • Original commit messages above
  • I cherry-picked the changes from [REDACTED] into develop
  • There were some conflicts

Issue

PRSDM-6549

Testing

Load a doc site. There should be no outgoing calls for jquery and bootstrap
All functionality and styling should remain the same

Checklist before merging

  • Did you test your changes locally?
  • Did you update the CHANGELOG?
  • Is the documentation updated for this change? (If Required)

@Zalaras
refactor: Stop loading external resources (#311)
b42c1e3 
* Update jQuery to 3.6 to match what's being loaded from code.jquery.com

* Add boostrap.min.css that's being loaded externally

* Move glyphicons to the path bootstrap expects

* Stop loading scripts/CSS from external CDN domains

* Fix invalid href on presidium-enterprise.js <link rel="preload">

* chore: update changelog

---------

Co-authored-by: Alexey Bezhan <[email protected]>
@Zalaras Zalaras requested a review from a team as a code owner October 23, 2024 21:07
@Zalaras Zalaras requested review from christopherbrunsdon, mpilo-khathwane, SamShiels, aLR8, julianbyte, DustinFischer and noe-span and removed request for a team October 23, 2024 21:07
@Zalaras Zalaras merged commit 8fa80be into develop Oct 24, 2024
1 check passed
@Zalaras Zalaras deleted the stop-loading-external-content branch October 24, 2024 12:24
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@julianbyte julianbyte mentioned this pull request Dec 10, 2024
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmorake kmorake kmorake approved these changes

@CharlRitterDev CharlRitterDev CharlRitterDev approved these changes

@christopherbrunsdon christopherbrunsdon Awaiting requested review from christopherbrunsdon christopherbrunsdon is a code owner automatically assigned from SPANDigital/span-presidium-dev

@mpilo-khathwane mpilo-khathwane Awaiting requested review from mpilo-khathwane mpilo-khathwane is a code owner automatically assigned from SPANDigital/span-presidium-dev

@SamShiels SamShiels Awaiting requested review from SamShiels SamShiels is a code owner automatically assigned from SPANDigital/span-presidium-dev

@aLR8 aLR8 Awaiting requested review from aLR8 aLR8 is a code owner automatically assigned from SPANDigital/span-presidium-dev

@julianbyte julianbyte Awaiting requested review from julianbyte julianbyte is a code owner automatically assigned from SPANDigital/span-presidium-dev

@DustinFischer DustinFischer Awaiting requested review from DustinFischer DustinFischer is a code owner automatically assigned from SPANDigital/span-presidium-dev

@noe-span noe-span Awaiting requested review from noe-span noe-span is a code owner automatically assigned from SPANDigital/span-presidium-dev

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zalaras @CharlRitterDev @kmorake