Feature/bugfixes and tweaks #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the Maven Failsafe Plugin to run Integration Tests. UnitTest which require external devices is moved to integration-test phase.
- added a toString implementation for ZonePlayer - added containsZonePlayer function to the ZonePlayerModel - added a dumpDevice to RemoteDeviceHelper which takes a Device instead. This is to allow local devices in the future(side project)
Added NULL pointer check - AudioServiceUnavailable is a implementation of AbstractService, but as the service is unavalable the service is initialised to NULL AbstractService checked for serviceType on this NULL Object.
- ZoneCommandDispatcher is a singleton, only one instance should be allowed. - SonosState no longer creates its own ZoneCommandDispatcher instance
- replaced 'salon' and 'chambre' strings in ClientIT with a variable to allow switching between sonos setups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Serge
Bug fixes and unobstructive tweaks extracted from, the now closed pull request #8
cheers
Phylock