Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for timeouts in asio/server #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moralismercatus
Copy link
Collaborator

This is an addition only. It does not change any existing functionality.
Server::open_connection_wait() is given an overload that takes a time
duration. The connection attempt will abort if not made within the given
time.

This is an addition only. It does not change any existing functionality.
Server::open_connection_wait() is given an overload that takes a time
duration. The connection attempt will abort if not made within the given
time.
@likebreath
Copy link
Collaborator

@moralismercatus Thanks for the PR.

Have you run regression test on this change?

And what is the plan for fixing the problem of using Server::open_connection_wait() without timeout? I am assuming you are only adding a new Server::open_connection_wait() with timeout, but it is not being used. Please correct me if I misunderstood it.

@moralismercatus
Copy link
Collaborator Author

I have successfully compiled it on guest and host. As it doesn't effect the functionality, I didn't run any regression tests.

You are correct. The new function is not being used.

There are a few places where the new function needs to be used. In fact, I believe it should replace all existing open_connect_wait() calls. I'll have that implemented soon. I'd like to have this addition as a separate PR, so I can get more familiar with the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants