Create contribution guidelines for people who actually read important documents #119
Conversation
|
Should I get this on the play store? I recently got my licence and promise to keep updated with GitHub version and never add ads |
|
Nah, this is far from ready. Remember the backlash Dolphin got when it was first put on Play? Could you imagine all the bloat on the issue tracker once it gets there in its current state? Not to mention this is not even official. Like, if SachinVin wants, then okay, why not, but I just don't think it's a wise move currently. Also, I'm kinda OOTL right now, but is this still being actively developed now that preparations of an official port have begun? |
|
SachinVin can you update emulator using the same system from new version of citra emulator from which pokemon x is running smoothly ? |
|
Well that would require pulling the new audio code from citra, which requires new core code. However, that core code is incompatible with SachinVin's hacky GLES renderer (memory and core timing have been revamped, looks like everything is going non-static now, but I might be wrong, not really a cpp person). It's not anything deal-breaking but it'd mean SachinVin would have to either integrate those changes into their renderer or push the ES hacks into the current video core (probably the easier way). Depends on if they want to dive deep into all the workarounds without those falling apart. I tried to hack together a build with the new audio core, but mixing the two branches was way above my cpp knowledge (gained from the similarity with Java). Also, ffmpeg is another thing, but it looks like that can be glued in on Android as well (there might be issues with licensing though). |
|
Why is Vulkan not possible? Most devices good enough to run this have at least Nougat and this Vulkan support |
|
It indeed is possible. But noone will probably ever do that. The OpenGL ES backend is a slightly modified OpenGL backend of PC Citra. If Vulkan were to be supported, it would first have to be implemented into the PC version. And the small performance gain that would eventually appear after a few years of polishing and perfecting would not be worth it. |
|
I just found that energy cube already posted it heres the link https://play.google.com/store/apps/details?id=org.citra.citra_android it works fine on my lg g7 but I'm not sure if this is a good thing |
|
@forthesafeofnealandfuller Ouch that's painful, isn't the license for google play like $50? |
|
@BenNottelling Last time I checked, it was a one time payment of $25. This is also completely irrelevant to the PR whatsoever (though it's not gonna get merged anyway as this repo is pretty much dead and SachinVin is contributing to the official one now). |
|
@HelloOO7 Oh that's not as bad, I bought mine a long while ago so I couldn't really remember.. |
These guidelines refer to a wiki page of known issues. As these cannot be merged via a PR, you should make a new wiki page called "Known Issues" from this paste or this wiki page.