Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up inst/config/workflow #54

Merged
merged 7 commits into from
Apr 23, 2021
Merged

Clean up inst/config/workflow #54

merged 7 commits into from
Apr 23, 2021

Conversation

jwildfire
Copy link
Contributor

@jwildfire jwildfire commented Apr 21, 2021

Summary

This PR migrates/deletes functions in the inst/config/workflow folder:

Test notes

Confirm that shift table and lab distribution work as expected in safetyGraphics and in the exported html.

devtools::install_github("safetyGraphics/safetyCharts", ref="fix-43-50")
library(safetyCharts)
devtools::install_github("safetyGraphics/safetyGraphics", ref="reports-updates")
library(safetyGraphics)
safetyGraphics::safetyGraphicsApp()

@jwildfire jwildfire requested a review from elimillera April 21, 2021 14:47
@jwildfire
Copy link
Contributor Author

Merge this after #52

@jwildfire jwildfire self-assigned this Apr 21, 2021
@jwildfire jwildfire changed the title Move tplyr shift table to R Clean up inst/config/workflow Apr 21, 2021
Copy link
Contributor

@elimillera elimillera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but looks good

@@ -1,6 +1,6 @@
label: Shift Table {Tplyr} + {kable}
type: html
domain: multiple
pacakage: Tplyr
package: safetyCharts
workflow:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this yaml need the export?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't hurt to add it, but will default to TRUE if nothing is provided.

@jwildfire jwildfire merged commit a7eca66 into dev Apr 23, 2021
@jwildfire jwildfire deleted the fix-43-50 branch March 23, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants