-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up inst/config/workflow #54
Conversation
Merge this after #52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question but looks good
@@ -1,6 +1,6 @@ | |||
label: Shift Table {Tplyr} + {kable} | |||
type: html | |||
domain: multiple | |||
pacakage: Tplyr | |||
package: safetyCharts | |||
workflow: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this yaml need the export?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't hurt to add it, but will default to TRUE if nothing is provided.
Summary
This PR migrates/deletes functions in the inst/config/workflow folder:
/R/tplyr_shift_chart.R
. This seems to deal with the dependency issues and fix the shift table, which now renders. Still need to do tplyr renderers not working in newest safetyGraphics Build #53 before v1.0 to have full safetyGraphics functionality./R/mod_lab_distribution.R
and add documentation./inst/config/workflow/safety_histogram_chart.R
for now. Will deal with that in WIP: safetyHistogram updates #45Test notes
Confirm that shift table and lab distribution work as expected in safetyGraphics and in the exported html.