Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PORTALS-3398: fix type issue #1533

Merged
merged 3 commits into from
Jan 30, 2025
Merged

PORTALS-3398: fix type issue #1533

merged 3 commits into from
Jan 30, 2025

Conversation

jay-hodgson
Copy link
Member

Error does not show up locally (on build or in the IDE), so it's difficult to test. This is my initial attempt to fix

@jay-hodgson
Copy link
Member Author

jay-hodgson commented Jan 30, 2025 •
edited
Loading

Running pnpm type-check I could test the issue locally. Locally I ended up casting it to the type that was being reported by the typecheck to figure it out in the IDE. No change in runtime behavior

@jay-hodgson jay-hodgson requested a review from nickgros January 30, 2025 20:00
@jay-hodgson jay-hodgson merged commit cec0f76 into Sage-Bionetworks:main Jan 30, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickgros nickgros nickgros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jay-hodgson @nickgros