SWC-7236 #1541
Merged
SWC-7236 #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nickgros
commented
Jan 31, 2025
nickgros
commented
- Fix column resizing issue
- SynapseTable: set initial column width to 200 (default is 150)
nickgros
commented
Jan 31, 2025
| @@ -153,6 +153,7 @@ export function SynapseTable(props: SynapseTableProps) { | |||
| id: selectColumn.name, | |||
| enableSorting: isSortableColumn(selectColumn.columnType), | |||
| enableResizing: true, | |||
| size: 200, | |||
There was a problem hiding this comment.
For Synapse Tables, make the initial width of each column slightly wider
nickgros
commented
Jan 31, 2025
| }, [ | ||
| table.getState().columnSizingInfo, | ||
| table.getState().columnSizing, | ||
| table.getState().columnVisibility, // If a column is added, its width should be recalculated |
There was a problem hiding this comment.
Fixes an occasional bug where these CSS variables would be initialized before SynapseTable had configured its visible columns.
nickgros
commented
Jan 31, 2025
| @@ -89,6 +94,7 @@ export default function StyledTanStackTable< | |||
| {...tableSlotProps} | |||
| style={{ | |||
| ...columnSizeVars, | |||
| tableLayout: 'fixed', | |||
There was a problem hiding this comment.
Fixes the re-sizing issue. This seems to work well for both dynamic-width tables and fullWidth (100%) tables
jay-hodgson
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.