code review feedback

synapseclient/core/upload/multipart_upload.py

@@ -10,7 +10,6 @@
 
 import concurrent.futures
 from contextlib import contextmanager
-import hashlib
 import json
 import math
 import mimetypes
@@ -30,7 +29,7 @@
     SynapseUploadAbortedException,
     SynapseUploadFailedException,
 )
-from synapseclient.core.utils import md5_for_file, MB, Spinner
+from synapseclient.core.utils import md5_fn, md5_for_file, MB, Spinner
 
 # AWS limits
 MAX_NUMBER_OF_PARTS = 10000
@@ -478,11 +477,6 @@ def multipart_upload_file(
     def part_fn(part_number):
         return _get_file_chunk(file_path, part_number, part_size)
 
-    def md5_fn(part, _):
-        md5 = hashlib.new("md5", usedforsecurity=False)
-        md5.update(part)
-        return md5.hexdigest()
-
     return _multipart_upload(
         syn,
         dest_file_name,
@@ -530,11 +524,6 @@ def multipart_upload_string(
      https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.17
     """
 
-    def md5_fn(part, _):
-        md5 = hashlib.new("md5", usedforsecurity=False)
-        md5.update(part)
-        return md5.hexdigest()
-
     data = text.encode("utf-8")
     file_size = len(data)
     md5_hex = md5_fn(data, None)

synapseclient/core/utils.py

@@ -57,6 +57,18 @@ def md5_for_file(filename, block_size=2 * MB, callback=None):
     return md5
 
 
+def md5_fn(part, _):
+    """Calculate the MD5 of a file-like object.
+
+    :part -- A file-like object to read from.
+
+    :returns: The MD5
+    """
+    md5 = hashlib.new("md5", usedforsecurity=False)
+    md5.update(part)
+    return md5.hexdigest()
+
+
 def download_file(url, localFilepath=None):
     """
     Downloads a remote file.

tests/integration/synapseclient/core/test_caching.py

@@ -181,7 +181,7 @@ def thread_get_and_update_file_from_Project(
             syn.logger.warning(
                 f"thread_get_and_update_file_from_Project()::get_all_ids_from_Project timed out, [project: {project.id}]"
             )
-        if len(id) <= 0:
+        if len(id) == 0:
             sleep_for_a_bit()
             continue
 

tests/integration/synapseclient/test_command_line_client.py

@@ -615,7 +615,7 @@ def test_command_get_recursive_and_query(test_state):
 
     schema1 = test_state.syn.store(
         Schema(
-            name="Foo Table_test_command_get_recursive_and_query",
+            name=str(uuid.uuid4()),
             columns=cols,
             parent=project_entity,
         )

tests/unit/synapseclient/core/upload/unit_test_multipart_upload.py

@@ -23,12 +23,7 @@
     pool_provider,
     UploadAttempt,
 )
-
-
-def md5_fn(part, _):
-    md5 = hashlib.new("md5", usedforsecurity=False)
-    md5.update(part)
-    return md5.hexdigest()
+from synapseclient.core.utils import md5_fn
 
 
 class TestUploadAttempt: