Force flush and close span_processor

Sage-Bionetworks · Nov 6, 2023 · f4bd8ac · f4bd8ac
1 parent d1e6f83
commit f4bd8ac
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -147,8 +147,9 @@ jobs:
             pytest -sv tests/integration/synapseclient/test_command_line_client.py
           fi
       - uses: actions/upload-artifact@v3
+        if: ${{ contains(fromJSON('["3.9"]'), matrix.python) }}
         with:
-          name: opentelemetry_traces
+          name: opentelemetry_traces_${{ matrix.os }}
           path: tests/integration/otel
 
   # on a GitHub release, build the pip package and upload it as a GitHub release asset

diff --git a/tests/integration/conftest.py b/tests/integration/conftest.py
@@ -149,14 +149,15 @@ def setup_otel():
             path = f"tests/integration/otel/{file_name}"
             utils.touch(path)
             export_file = open(path, "w", encoding="utf-8")
-            trace.get_tracer_provider().add_span_processor(
-                BatchSpanProcessor(ConsoleSpanExporter(out=export_file))
-            )
+            span_processor = BatchSpanProcessor(ConsoleSpanExporter(out=export_file))
+            trace.get_tracer_provider().add_span_processor(span_processor)
     else:
         trace.set_tracer_provider(TracerProvider(sampler=ALWAYS_OFF))
 
     yield
 
     # Teardown
     if export_file:
+        span_processor.force_flush()
+        span_processor.shutdown()
         export_file.close()