-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYNPY-1304] Introduction of OpenTelemetry #1007
Conversation
.github/workflows/build.yml
Outdated
@@ -63,7 +63,7 @@ jobs: | |||
path: | | |||
${{ steps.get-dependencies.outputs.site_packages_loc }} | |||
${{ steps.get-dependencies.outputs.site_bin_dir }} | |||
key: ${{ runner.os }}-${{ matrix.python }}-build-${{ env.cache-name }}-${{ hashFiles('setup.py') }}-v7 | |||
key: ${{ runner.os }}-${{ matrix.python }}-build-${{ env.cache-name }}-${{ hashFiles('setup.py') }}-v7-otel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be reverted before merge - This is to allow the CICD pipeline to install the new dependencies and not used the cached version
Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-11-03 16:13:56 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 This looks great - id say since this is the intro to open telemetry, its ok for this PR to be so big. We can take the sprint review to show everyone how this works.
Background SPIKE:
Solution:
This PR introduces 3 new dependencies to the Synapse Python project around OpenTelemetry. I have also manually instrumented the code in areas where it would be programmatically entered, and any areas where I/O is expected to occur for communication with our Rest APIs.
Please carefully review the changes to the README around this and let me know areas you'd like it improved.
JaegerUI to view traces: