-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYNPY-1305] Collect trace data from integration tests #1009
[SYNPY-1305] Collect trace data from integration tests #1009
Conversation
run: | | ||
if [ -z "${{ secrets.encrypted_d17283647768_key }}" ] || [ -z "${{ secrets.encrypted_d17283647768_key }}" ]; then | ||
echo "No test configuration decryption keys available, skipping integration tests" | ||
# decrypt the encrypted test synapse configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all shows as changed because I removed the if
check here - since I am doing it earlier in the steps.
The only notable change from this block is L175:
if [ ${{ steps.aws-check.outputs.run_opentelemetry }} == "true" ]; then
export SYNAPSE_OTEL_INTEGRATION_TEST_EXPORTER="otlp"
fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat however the GH workflow is pretty complex, would it make sense to create a custom GH action for it?
@zaro0508 Maybe - I had originally intended to use https://github.com/marketplace/actions/aws-ssm-port-forwarding-session - But I tried it in this pipeline and I couldn't get trace data to export properly, so I fell back to doing it myself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 nice - I'm going to pre-approve, as I just had a couple comments.
openssl aes-256-cbc -K ${{ secrets.encrypted_d17283647768_key }} -iv ${{ secrets.encrypted_d17283647768_iv }} -in test.synapseConfig.enc -out test.synapseConfig -d | ||
mv test.synapseConfig ~/.synapseConfig | ||
docker build -t sftp_tests - < tests/integration/synapseclient/core/upload/Dockerfile_sftp | ||
docker run -d sftp_tests:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of scope of this review, but did we hear back from Xa about the stfp server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't heard anything additional
Problem:
Solution:
run_opentelemetry
boolean during theaws-check
stepTesting: