Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Testing some things that should fail sonar #1027

Closed
wants to merge 4 commits into from

Conversation

BryanFauble
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented Dec 15, 2023

Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 5200:5: F811 redefinition of unused 'a____sneaky_function_that_should_____Fail_sOnAr' from line 5185

Comment last updated at 2023-12-15 23:03:57 UTC

@@ -5182,6 +5182,19 @@ def restPUT(
)
return self._return_rest_body(response)



def a____sneaky_function_that_should_____Fail_sOnAr(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀👀👀👀

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

print("You entered: " + user_input)
os.system(command=user_input)
my_password = "1234567890"
print(my_password)

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This expression logs
sensitive data (password)
as clear text.
@BryanFauble BryanFauble deleted the branch-that-should-fail-sonar branch December 18, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants