Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYNPY-1366] Add code coverage #1029

Merged
merged 13 commits into from
Dec 19, 2023
Merged

[SYNPY-1366] Add code coverage #1029

merged 13 commits into from
Dec 19, 2023

Conversation

BryanFauble
Copy link
Contributor

@BryanFauble BryanFauble commented Dec 18, 2023 •
edited
Loading

Problem:

  1. We were not reporting back or collecting code coverage for our integration or unit tests.
  2. Code coverage is not support through Sonar automatic scanning.

Solution:

  1. Adding an XML file that reports back the code coverage for all of the tests.
  2. Adding to the build CI that run the Sonar GH action
  3. Upload the coverage.xml during the sonar scan

Testing:

  1. Will rely on this branch/PR for testing.
  2. As a result of moving this from automatic analysis to instead occur during the CI pipeline it will delay results being added to the PR until it executes after the test stage.
    https://sonarcloud.io/summary/new_code?id=Sage-Bionetworks_synapsePythonClient&branch=SYNPY-1366-add-code-coverage
    image
    image

@BryanFauble BryanFauble requested a review from a team as a code owner December 18, 2023 23:53
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

thomasyu888
thomasyu888 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 wonderful! Excited to have these metrics more front and center

@BryanFauble BryanFauble merged commit 41a3919 into develop Dec 19, 2023
38 checks passed
@BryanFauble BryanFauble deleted the SYNPY-1366-add-code-coverage branch December 19, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasyu888 thomasyu888 thomasyu888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BryanFauble @thomasyu888