-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYNPY-1298] flakey integration tests #999
Conversation
Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-10-30 20:36:53 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I added some comments.
tests/unit/synapseclient/core/upload/unit_test_multipart_upload.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 LGTM! @BWMac if you wanted to review for for cross training, that'd be great, but it doesn't block the merging of this ticket.
Problem:
Several unit tests are very flaky, or timeout after 6 hours.
Solution:
Introduced 2 new packages:
func-timeout
is to time bound some callsrerunfailures
allows us to add a decorator to tests and conditionally re-run them a number of time (It's rare for them to fail multiple times in a row)Testing: