feat(text-editor): replaces draftjs with lexical #7149
+4,977
−5,439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienrobson-sage
force-pushed
the
FE-7018-text-editor-rewrite
branch
5 times, most recently
from
9b021b8 to
a5d0b45
Compare
edleeks87
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Really good stuff @damienrobson-sage, I really like the structure/approach you've adopted, I've left some comments but in general they're pretty trivial
src/components/rich-text-editor/plugins/Placeholder/placeholder.component.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Good work with this. Just a few bugs I spotted when messing around with the new component.
Seems that the Bold and Italic options aren't selectable on initial render.
Screen.Recording.2025-01-13.at.10.58.19.mov
Bold and Italic cannot be used together.
Screen.Recording.2025-01-13.at.10.59.51.mov
If you select the bullet point list before typing, it doesn't apply the formatting to the text.
Screen.Recording.2025-01-13.at.11.02.24.mov
damienrobson-sage
force-pushed
the
FE-7018-text-editor-rewrite
branch
from
46ff8df to
5defeb6
Compare
damienrobson-sage
force-pushed
the
FE-7018-text-editor-rewrite
branch
2 times, most recently
from
ae48e7e to
c0c6101
Compare
src/components/text-editor/__internal__/plugins/Toolbar/toolbar.component.tsx
Outdated
Show resolved
Hide resolved
damienrobson-sage
force-pushed
the
FE-7018-text-editor-rewrite
branch
from
c0c6101 to
a57ec60
Compare
damienrobson-sage
force-pushed
the
FE-7018-text-editor-rewrite
branch
from
a57ec60 to
d0a0b18
Compare
edleeks87
reviewed
Jan 17, 2025
damienrobson-sage
force-pushed
the
FE-7018-text-editor-rewrite
branch
from
d0a0b18 to
ded2a65
Compare
damienrobson-sage
force-pushed
the
FE-7018-text-editor-rewrite
branch
from
ded2a65 to
ea9dc2b
Compare
edleeks87
previously approved these changes
Jan 20, 2025
src/components/text-editor/__snapshots__/text-editor.test.tsx.snap
Outdated
Show resolved
Hide resolved
DipperTheDan
previously approved these changes
Jan 20, 2025
DipperTheDan
previously approved these changes
Jan 23, 2025
edleeks87
previously approved these changes
Jan 23, 2025
damienrobson-sage
dismissed stale reviews from edleeks87 and DipperTheDan
via
6b145e2
damienrobson-sage
force-pushed
the
FE-7018-text-editor-rewrite
branch
2 times, most recently
from
6b145e2 to
a1bccb5
Compare
harpalsingh
added
Passed UX QA
Passed a11y Review
and removed
Pending UX QA
Pending a11y Review
labels
|
Reviewed both UX and A11y based on requested changes and gave Accessibility and "at desk" demo of this and all good. |
DipperTheDan
previously approved these changes
Jan 28, 2025
edleeks87
previously approved these changes
Jan 28, 2025
damienrobson-sage
dismissed stale reviews from edleeks87 and DipperTheDan
via
8f8e622
damienrobson-sage
force-pushed
the
FE-7018-text-editor-rewrite
branch
from
a1bccb5 to
8f8e622
Compare
The draftjs package is no longer maintained; a decision has been reached to rewrite the TextEditor component using Lexical BREAKING CHANGE: Whilst the intention is to implement a straight-up replacement and maintain as much functionality as possible, there may be differences that customers need to be made aware of. These will be communicated separately as necessary.
damienrobson-sage
force-pushed
the
FE-7018-text-editor-rewrite
branch
from
8f8e622 to
bf308f8
Compare
… read out by screen readers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The draftjs package is no longer maintained; a decision has been reached to rewrite the TextEditor component using Lexical
BREAKING CHANGE: Whilst the intention is to implement a straight-up replacement and maintain as much functionality as possible, there may be differences that customers need to be made aware of. These will be communicated separately as necessary.
Proposed behaviour
Rebuild the
TextEditorcomponent from the ground up using LexicalCurrent behaviour
The
TextEditorcomponent is built arounddraftjs, which is no longer maintained.Checklist
d.tsfile added or updated if requiredQA
Testing instructions
Using the provided playground in Storybook's
Testsection will allow you to view and interact with the new editor in several states