fix(date-picker): date-picker within a popover-container closes when tabbing #7188
+139
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the
handleOnDayKeyDown
handler inside theDatePicker
to prevent interfering with theuseFocusPortalContent
hook.Proposed behaviour
popover-after.mp4
Current behaviour
When using the keyboard navigation the
handleOnDayKeyDown
handler inside theDatePicker
focuses the second input of the date range.useFocusPortalContent
determines the last item is focused. On the next keyboard navigation event, the focus moves from the second date range input inside of the react day picker. Since , from theuseFocusPortalContent
perspective we just lost the focus on the last element, it will close the popover.popover-before.mp4
Checklist
d.ts
file added or updated if requiredQA
Additional context
Testing instructions