udpnat2: Add timeout check

SagerNet · Nov 26, 2024 · a8f5bf4 · a8f5bf4
1 parent 30e9d91
commit a8f5bf4
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/common/udpnat2/service.go b/common/udpnat2/service.go
@@ -35,6 +35,9 @@ type Metrics struct {
 }
 
 func New(handler N.UDPConnectionHandlerEx, prepare PrepareFunc, timeout time.Duration, shared bool) *Service {
+	if timeout == 0 {
+		panic("invalid timeout")
+	}
 	var cache freelru.Cache[netip.AddrPort, *natConn]
 	if !shared {
 		cache = common.Must1(freelru.New[netip.AddrPort, *natConn](1024, maphash.NewHasher[netip.AddrPort]().Hash32))
@@ -80,11 +83,10 @@ func (s *Service) Start() error {
 	return nil
 }
 
-func (s *Service) Close() error {
+func (s *Service) Close() {
 	s.closeOnce.Do(func() {
 		close(s.doneChan)
 	})
-	return nil
 }
 
 func (s *Service) NewPacket(bufferSlices [][]byte, source M.Socksaddr, destination M.Socksaddr, userData any) {