Sitetils refactor #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inor stylistic changes
…esary method param for deleterecord
|
Thanks @Mike-Cleaver-LB for these contributions. I will merge these at some point in the new year when I have more time to be available to support it. The JSON parser change is fundamental to how the component displays so I'd like to do some testing around this first so I'm clear in my own head how it works. |
…o a mapped field. Fix logic check for mapping form fields to person mobile and person email correctly. Fix logic for username field on user to allow an override from metadata.
… tracking issues.
…inor stylistic changes
…esary method param for deleterecord
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the first part (35cc78c and 00d8138) is just prettier reformatting. Whitespace en masse.
Then I did some work that doesn't change much, (NPE e273742, use fake metadata 6453d3d, updating readme to have more complete dev setup instructions cbed116, updated the tests some more to improve coverage 3e29db6, 5d1cbb6)
then did a rework of the JSON generation code in the siteutils class so you're not hand writing JSON (eaafdc4)
I previously was going to split this into multiple PRs but it's a mess trying to keep my stuff up to date