Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1494 add search to admin users page #1657

Merged
merged 17 commits into from
Feb 6, 2025

Conversation

Lidavic
Copy link
Contributor

@Lidavic Lidavic commented Jan 16, 2025

Adds a search bar to the "Brukere" tab in the admin panel (kontrollpanel) that you can use to search for a user by their first and last name. (Also fixes a small error in the "Saksdokumenter" tab)

bilde
bilde

closes #1494

@Lidavic Lidavic self-assigned this Jan 16, 2025
@Lidavic Lidavic linked an issue Jan 16, 2025 that may be closed by this pull request
Copy link
Contributor

@johannegg johannegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could be an idea to add debouncing to limit the number of searches. Could be a lot of users here later and too many searches can be a bit inefficient.

Copy link
Contributor

@emsoraffa emsoraffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Snorre98 Snorre98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

se kommentarer

frontend/src/PagesAdmin/UsersAdminPage/UsersAdminPage.tsx Outdated Show resolved Hide resolved
frontend/src/PagesAdmin/UsersAdminPage/UsersAdminPage.tsx Outdated Show resolved Hide resolved
Snorre98
Snorre98 previously approved these changes Feb 2, 2025
Copy link
Contributor

@Snorre98 Snorre98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗ se bort i fra denne ❗
Denne kan merges, så kan du fortsette på denne #1668

@Snorre98 Snorre98 dismissed their stale review February 2, 2025 16:22

found out that I would be ok to complete as planed

Copy link
Contributor

@Snorre98 Snorre98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se DM på Discord

frontend/src/PagesAdmin/UsersAdminPage/UsersAdminPage.tsx Outdated Show resolved Hide resolved
@Lidavic Lidavic requested a review from Snorre98 February 6, 2025 18:27
Copy link
Contributor

@Snorre98 Snorre98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Lidavic Lidavic merged commit 3827d23 into master Feb 6, 2025
5 checks passed
@Lidavic Lidavic deleted the 1494-add-search-to-admin-users-page branch February 6, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add search to admin users page
4 participants