test fix

Samsung · Jan 17, 2025 · 28b6d17 · 28b6d17
1 parent 943e166
commit 28b6d17
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/credsweeper/filters/value_pattern_check.py b/credsweeper/filters/value_pattern_check.py
@@ -101,7 +101,8 @@ def run(self, line_data: LineData, target: AnalysisTarget) -> bool:
 
         """
         if len(line_data.value) < self.pattern_len:
-            return True
+            # the filter cannot check short value
+            return False
 
         if self.equal_pattern_check(line_data.value):
             return True

diff --git a/tests/rules/common.py b/tests/rules/common.py
@@ -9,15 +9,15 @@ class BaseTestRule:
 
     def test_scan_p(self, file_path: pytest.fixture, lines: pytest.fixture,
                     scanner_without_filters: pytest.fixture) -> None:
-        provider = StringContentProvider(lines)
+        provider = StringContentProvider(lines, file_path=file_path)
         scan_result = scanner_without_filters.scan(provider)
         assert len(scan_result) == 1
 
-    @pytest.mark.parametrize("lines", [[""], ["String secret = new String()"], ["SZa6TWGF2XuWdl7c2s2xB1iSlnZJLbvH"]])
+    @pytest.mark.parametrize("lines", [[""], ["String secret = new String('p*****');"], ["SZa6TWGF2XuWdl7c2s2xB1iSlnZJLbvH"]])
     def test_scan_n(self, file_path: pytest.fixture, lines: List[str], scanner: pytest.fixture) -> None:
-        provider = StringContentProvider(lines)
+        provider = StringContentProvider(lines, file_path=file_path)
         scan_result = scanner.scan(provider)
-        assert len(scan_result) == 0
+        assert len(scan_result) == 0, scan_result[0]
 
 
 class BaseTestNoQuotesRule: