Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update --doc rules only #447

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Update --doc rules only #447

merged 7 commits into from
Nov 1, 2023

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Oct 25, 2023

Description

Please include a summary of the change and which is fixed.

  • Fix ValueAllowlistCheck filter to skip case "abcde***********"
  • update rules for doc only

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e20b010) 90.78% compared to head (fd375ec) 90.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
- Coverage   90.78%   90.71%   -0.08%     
==========================================
  Files         125      125              
  Lines        4179     4179              
  Branches      662      662              
==========================================
- Hits         3794     3791       -3     
- Misses        252      253       +1     
- Partials      133      135       +2     
Files Coverage Δ
credsweeper/filters/value_allowlist_check.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek marked this pull request as ready for review October 26, 2023 06:05
@babenek babenek requested a review from a team as a code owner October 26, 2023 06:05
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ValueAllowlistCheck filter has been updated and ValuePatternCheck filter has been added to some filters for --doc option.

LGTM 👍

Copy link
Contributor

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@babenek babenek merged commit 3467170 into Samsung:main Nov 1, 2023
29 checks passed
@babenek babenek deleted the auxiliary branch November 1, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants