Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ML from well known pattern #448

Merged
merged 6 commits into from
Nov 1, 2023
Merged

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Oct 26, 2023

Description

Please include a summary of the change and which is fixed.

  • removed extra "use_ml: false" - it is by default
  • disabled ML for good recognised patterns
  • Fix Benchmark scores

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3467170) 90.71% compared to head (b66eb69) 90.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   90.71%   90.66%   -0.05%     
==========================================
  Files         125      125              
  Lines        4179     4179              
  Branches      662      662              
==========================================
- Hits         3791     3789       -2     
- Misses        253      254       +1     
- Partials      135      136       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek marked this pull request as ready for review October 30, 2023 07:11
@babenek babenek requested a review from a team as a code owner October 30, 2023 07:11
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually a little worried about remove ML from many rules..
But the benchmark results prove it, so let's merge it this time.

LGTM 👍

Copy link
Contributor

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@Yullia Yullia self-requested a review November 1, 2023 09:17
@babenek babenek merged commit f76d16a into Samsung:main Nov 1, 2023
29 checks passed
@babenek babenek deleted the withoutml branch November 1, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants