Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed api_validations #633

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Removed api_validations #633

merged 5 commits into from
Dec 16, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Dec 12, 2024

Description

Please include a summary of the change and which is fixed.

  • Removed API_VALIDATIONS
  • Merged some rules
  • Update pattern for Stripe Credentials with new length

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek marked this pull request as ready for review December 13, 2024 13:36
@babenek babenek requested a review from a team as a code owner December 13, 2024 13:36
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit bitter to remove validation feature from CredSweeper but it is needed for improving CredSweeper more.

LGTM 👍

@babenek babenek merged commit 1545407 into Samsung:main Dec 16, 2024
32 checks passed
@babenek babenek deleted the novalidations branch December 16, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants