Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert/python] Introduce LossRegistry #14574

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

ragmani
Copy link
Contributor

@ragmani ragmani commented Jan 22, 2025

This commit introduces LossRegistries.

  • create_loss : Create a loss instance by name
  • map_loss_function_to_enum : Map a loss instance to the appropriate enum value.

ONE-DCO-1.0-Signed-off-by: ragmani [email protected]

@ragmani ragmani requested a review from a team January 22, 2025 03:47
@ragmani ragmani added the PR/ready for review It is ready to review. Please review it. label Jan 22, 2025
@ragmani
Copy link
Contributor Author

ragmani commented Jan 22, 2025

For #14505
Draft : #14492

This commit introduces LossRegistries that can create loss functions by names.

ONE-DCO-1.0-Signed-off-by: ragmani <[email protected]>
@ragmani ragmani force-pushed the onert/python/add_loss_registry branch from 242352f to ff4393b Compare January 22, 2025 03:49
zetwhite
zetwhite previously approved these changes Jan 22, 2025
Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ragmani ragmani force-pushed the onert/python/add_loss_registry branch from fb36281 to f67d390 Compare January 22, 2025 04:48
@ragmani ragmani requested a review from a team January 22, 2025 04:51
@ragmani
Copy link
Contributor Author

ragmani commented Jan 22, 2025

I additionally added "map_loss_function_to_enum".

@ragmani ragmani added PR/NO MERGE Please don't merge. I'm still working on this :) and removed PR/ready for review It is ready to review. Please review it. labels Jan 23, 2025
@ragmani ragmani added PR/ready for review It is ready to review. Please review it. and removed PR/NO MERGE Please don't merge. I'm still working on this :) labels Jan 23, 2025
Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 6036cd2 into Samsung:master Jan 23, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants