-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[onert/python] Introduce LossRegistry #14574
Merged
hseok-oh
merged 3 commits into
Samsung:master
from
ragmani:onert/python/add_loss_registry
Jan 23, 2025
Merged
[onert/python] Introduce LossRegistry #14574
hseok-oh
merged 3 commits into
Samsung:master
from
ragmani:onert/python/add_loss_registry
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces LossRegistries that can create loss functions by names. ONE-DCO-1.0-Signed-off-by: ragmani <[email protected]>
ragmani
force-pushed
the
onert/python/add_loss_registry
branch
from
January 22, 2025 03:49
242352f
to
ff4393b
Compare
zetwhite
previously approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ragmani
force-pushed
the
onert/python/add_loss_registry
branch
from
January 22, 2025 04:48
fb36281
to
f67d390
Compare
I additionally added "map_loss_function_to_enum". |
ragmani
added
PR/NO MERGE
Please don't merge. I'm still working on this :)
and removed
PR/ready for review
It is ready to review. Please review it.
labels
Jan 23, 2025
ragmani
added
PR/ready for review
It is ready to review. Please review it.
and removed
PR/NO MERGE
Please don't merge. I'm still working on this :)
labels
Jan 23, 2025
zetwhite
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hseok-oh
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces LossRegistries.
ONE-DCO-1.0-Signed-off-by: ragmani [email protected]