-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Update protobuf to 3.20 #14589
base: release/1.28.1
Are you sure you want to change the base?
Conversation
This commit updates the Protobuf library to a newer version due to the fixes this version contains. This is a backport of Samsung#14535 to the release branch ONE-DCO-1.0-Signed-off-by: Tomasz Dolbniak [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ah... this is for |
As I know know the background of this change, I cannot agree landing this PR in release branch. |
This change is required to release 1.28.1 and switch the NPU Compiler to this version. The protobuf update is required to eliminate the build breaks on Ubuntu 24 and enable the work on the NPU Compiler for people who use this OS (and can't downgrade). The same changes in the master branch can and will be used for the future releases but the NPU Compiler is not ready to use a release newer than 1.28.x because of breaking changes in the API. Please check |
What I can suggest; |
This commit updates the Protobuf library to a newer version due to the fixes this version contains.
This is a backport of #14535 to the release branch
ONE-DCO-1.0-Signed-off-by: Tomasz Dolbniak [email protected]