Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Update protobuf to 3.20 #14589

Open
wants to merge 1 commit into
base: release/1.28.1
Choose a base branch
from

Conversation

tomdol
Copy link
Contributor

@tomdol tomdol commented Jan 23, 2025

This commit updates the Protobuf library to a newer version due to the fixes this version contains.

This is a backport of #14535 to the release branch

ONE-DCO-1.0-Signed-off-by: Tomasz Dolbniak [email protected]

This commit updates the Protobuf library to a newer version due to the fixes this version contains.

This is a backport of Samsung#14535 to the release branch

ONE-DCO-1.0-Signed-off-by: Tomasz Dolbniak [email protected]
@tomdol tomdol mentioned this pull request Jan 23, 2025
Copy link
Contributor

@SlavikMIPT SlavikMIPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark requested a review from hseok-oh February 2, 2025 22:51
Copy link
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark
Copy link
Contributor

Ah... this is for release/1.28.1.
Are we going to release this version?
As I know this patch is for internal npu compiler but I don't know why this patch should land in this branch.

@seanshpark
Copy link
Contributor

As I know know the background of this change, I cannot agree landing this PR in release branch.
But also I don't disagree as I don't know what/why this is needed.
If someone has strong needs, he/she can take care, and please explain something.

@seanshpark seanshpark self-requested a review February 3, 2025 10:11
@tomdol
Copy link
Contributor Author

tomdol commented Feb 3, 2025

This change is required to release 1.28.1 and switch the NPU Compiler to this version. The protobuf update is required to eliminate the build breaks on Ubuntu 24 and enable the work on the NPU Compiler for people who use this OS (and can't downgrade).

The same changes in the master branch can and will be used for the future releases but the NPU Compiler is not ready to use a release newer than 1.28.x because of breaking changes in the API. Please check NPU_Compiler/pull/20425.

@seanshpark
Copy link
Contributor

20425 is my patch that repo maintainer rejected for some reason.
thanks for explaining the situation. as I understand,

  • some work on U24.04, cannot downgrade to U22.04 or U20.04
  • npu has some build breaks with U24.04 (I assume the codes are from this repo)

What I can suggest;
1/ use Docker of U22.04 or U20.04 on your U24.04
2/ fix rejected problem in ONE first to make the maintainer happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants