Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add the known issues section #14591

Open
wants to merge 1 commit into
base: release/1.28.1
Choose a base branch
from

Conversation

tomdol
Copy link
Contributor

@tomdol tomdol commented Jan 23, 2025

This commit adds the known issues section to the compiler build instructions.

This is a backport of #14573 to the release branch

This commit adds the known issues section to the compiler build instructions.

This is a backport of Samsung#14573 to the release branch

ONE-DCO-1.0-Signed-off-by: Tomasz Dolbniak <[email protected]>
Copy link
Contributor

@SlavikMIPT SlavikMIPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

## Known issues
There's a potential known build error when attempting to cross-compile for ARM32 using GCC 10.5.
You might encounter an error:
`comparison of unsigned expression in ‘< 0’ is always false [-Werror=type-limits]` reported from
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is rendered like

image

is this your intention?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obraz
This is how it looks for me and it matches how the master branch version is rendered https://github.com/Samsung/ONE/blob/master/docs/howto/how-to-build-compiler.md

What is the issue exactly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the issue exactly?

Source:

You might encounter an error:
comparison of unsigned expression in `

Rendered result:

You might encounter an error: comparison of unsigned expression in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line break after "You might encounter an error:" is just to avoid lines longer than 100 characters in the source code - #14535 (comment)

It's ok that the error message is rendered in the same line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

There's a workaround for it though - you can apply the following changes to both for loops
in the `CircleNodeMixins.h`:

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants