-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NUI] Reduce error log by the request of user #6572
base: API10
Are you sure you want to change the base?
Conversation
- Reduce error log print. - Limit trace call stack depth at 5, when the exception case of ViewSignal Disconnect by the request of GBM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some times 5 depth could be not enough as there are some abstract layers exists in the exceptional cases. but I understand why we restrict bt depth. let's see :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if the value(5) could be configured,
but since this is not yet confirmed and looks an experimental commit,
Lets see how it turns out.
@everLEEst 님, @lwc0917 님 수정하게된 이유는 아래에 근거 합니다.
signal Disconnect 에서 PLM 문제가 많이 나왔어서 try-catch 로 에러 상황에서 bt 를 찍는데 앱의 시작점인 Run 이 어쩔수 없이 찍혔습니다. => 이런 이유인데요, 5 depth 가 부족할 수는 있지만, 경험상 5개 내의 depth 에 해당 signal 의 이름이 찍혔던 것 같습니다. |
Description of Change
API Changes
nothing