Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI] Reduce error log by the request of user #6572

Open
wants to merge 1 commit into
base: API10
Choose a base branch
from

Conversation

dongsug-song
Copy link
Contributor

Description of Change

  • Reduce error log print.
  • Limit trace call stack depth at 5, when the exception case of ViewSignal Disconnect by the request of GBM.

API Changes

nothing

- Reduce error log print.
- Limit trace call stack depth at 5, when the exception case of ViewSignal Disconnect by the request of GBM.
@github-actions github-actions bot added the API10 Platform : Tizen 7.0 / TFM: tizen10.0 label Jan 11, 2025
Copy link
Contributor

@everLEEst everLEEst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some times 5 depth could be not enough as there are some abstract layers exists in the exceptional cases. but I understand why we restrict bt depth. let's see :)

Copy link
Contributor

@lwc0917 lwc0917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the value(5) could be configured,
but since this is not yet confirmed and looks an experimental commit,
Lets see how it turns out.

@dongsug-song
Copy link
Contributor Author

@everLEEst 님, @lwc0917
리뷰 감사합니다.

수정하게된 이유는 아래에 근거 합니다.
https://confluence.sec.samsung.net/pages/viewpage.action?pageId=1023920040
=>
안녕하세요. Error 상황의 로그 레벨이 적절한 상황입니다.

    public void Disconnect(System.Delegate func)
    {
        try
        {
            System.IntPtr ip = System.Runtime.InteropServices.Marshal.GetFunctionPointerForDelegate<System.Delegate>(func);
            {
                Interop.ActorSignal.Disconnect(SwigCPtr, new System.Runtime.InteropServices.HandleRef(this, ip));
                if (NDalicPINVOKE.SWIGPendingException.Pending) throw NDalicPINVOKE.SWIGPendingException.Retrieve();
            }
        }
        catch (global::System.Exception ex)
        {
            Tizen.Log.Fatal("NUI", $"[ERROR] exception! {ex}: {ex.Message}");
            Tizen.Log.Fatal("NUI", $"[ERROR] current threadID : {Thread.CurrentThread.ManagedThreadId}");
            Tizen.Log.Fatal("NUI", $"[ERROR] back trace!");
            global::System.Diagnostics.StackTrace st = new global::System.Diagnostics.StackTrace(true);
            for (int i = 0; i < st.FrameCount; i++)
            {
                global::System.Diagnostics.StackFrame sf = st.GetFrame(i);
                Tizen.Log.Fatal("NUI", " Method " + sf.GetMethod());   => 콜스택을 찍는데서 Application 의 시작점인 Run 이 어쩔수 없이 찍힙니다.
            }
        }
    }

signal Disconnect 에서 PLM 문제가 많이 나왔어서 try-catch 로 에러 상황에서 bt 를 찍는데 앱의 시작점인 Run 이 어쩔수 없이 찍혔습니다.
에러 상황이라서 로그 레벨은 맞다고 생각합니다. 너무 많다고 말씀하시니 bt 의 depth 를 max 5로 조정하도록 하겠습니다.
tizen_7.0, tizen 에 모두 반영 하도록 하겠습니다.
감사합니다.

=> 이런 이유인데요, 5 depth 가 부족할 수는 있지만, 경험상 5개 내의 depth 에 해당 signal 의 이름이 찍혔던 것 같습니다.
어떻게 보시는지요? DA 요청 사항인데 거부할까요? 의견 부탁드립니다. 감사합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API10 Platform : Tizen 7.0 / TFM: tizen10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants