Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/drivers/lcd/: Remove logo specific code from bus specific files #6614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

namanjain7
Copy link
Contributor

Reduces dependency from mipi_lcd.c by moving logo specific code to logo.c file. There are three functions defined inside logo.c file -: 1)lcd_logo_allocate_buffer(): It allocate buffer for logo data. If software rotation is enabled it utilizes software rotation buffer else a new buffer is created. 2)lcd_logo_fill_buffer(): It fills the logo buffer by identifying correct area. 3)lcd_logo_release_buffer(): It releases the logo buffer memory.

…i_lcd.c to logo.c

Reduces dependency from mipi_lcd.c by moving logo specific code to logo.c file.
There are three functions defined inside logo.c file -:
1)lcd_logo_allocate_buffer(): It allocate buffer for logo data. If software rotation is enabled it utilizes software rotation buffer else a new buffer is created.
2)lcd_logo_fill_buffer(): It fills the logo buffer by identifying correct area.
3)lcd_logo_release_buffer(): It releases the logo buffer memory.
@namanjain7
Copy link
Contributor Author

Remove logo specific code from bus specific files (mipi_lcd.c).
Logo operation functions are shifted to logo.c file and they are invoked from lcd driver HAL (lcd_dev.c).
Now there is no dependency of logo on specific BUS related files.

@namanjain7 namanjain7 changed the title os/drivers/lcd/: Refactor logo code. Move logo specific code from mipi_lcd.c to logo.c os/drivers/lcd/: Remove logo specific code from bus specific files Jan 6, 2025
@sunghan-chang
Copy link
Contributor

@namanjain7 Sorry, because of urgent issue, review is pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants