Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/board/rtl8730e: added BLE secure parameter setting, passkey display callback and passkey confirmation API #6620

Conversation

yeetee179
Copy link
Contributor

  • ble_manager_set_secure_param API is added to set BLE secure parameter
  • ble_server_passkey_display_cb is added inform app layer passkey
  • ble_manager_passkey_confirm is added to for passkey confirmation

…y callback and passkey confirmation API

- ble_manager_set_secure_param API is added to set BLE secure parameter
- ble_server_passkey_display_cb is added inform app layer passkey
- ble_manager_passkey_confirm is added to for passkey confirmation
Copy link
Contributor

@giwon-nam giwon-nam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change parameter type to pointer?

RETURN_RESULT(res, msg);
}

ble_result_e ble_manager_set_secure_param(ble_sec_param sec_param )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ble_result_e ble_manager_set_secure_param(ble_sec_param sec_param )
ble_result_e ble_manager_set_secure_param(ble_sec_param *sec_param)


ble_result_e ble_manager_set_secure_param(ble_sec_param sec_param )
{
blemgr_msg_s msg = {BLE_CMD_SEC_PARAM_SET, BLE_MANAGER_FAIL, (void *)(&sec_param), NULL};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
blemgr_msg_s msg = {BLE_CMD_SEC_PARAM_SET, BLE_MANAGER_FAIL, (void *)(&sec_param), NULL};
blemgr_msg_s msg = {BLE_CMD_SEC_PARAM_SET, BLE_MANAGER_FAIL, (void *)(sec_param), NULL};

…y callback and passkey confirmation API

- ble_manager_set_secure_param API is added to set BLE secure parameter
- ble_server_passkey_display_cb is added inform app layer passkey
- ble_manager_passkey_confirm is added to for passkey confirmation
@yeetee179 yeetee179 closed this Jan 17, 2025
@yeetee179
Copy link
Contributor Author

This PR is closed, a new PR is opened on #6635 with the same changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants