Remove config dependency to fix ps command issue #6634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to config dependency, ps command doesn't give correct output. So, this patch fix the issue by removing config dependency for CONFIG_SMP and CONFIG_SMP_NCPUS. Signed-off-by: neel-samsung <[email protected]>
Due to config dependency, ps command doesn't give correct output. So, this patch fix the issue by removing config dependency for CONFIG_SMP and CONFIG_SMP_NCPUS between Kernel and application. We hande it by introducing the syscall for obtaining the number CPUs while runtime. Signed-off-by: neel-samsung <[email protected]>
neel-samsung
force-pushed
the
remove_config_dep
branch
from
65b699c to
c1afe15
Compare
jeongarmy
reviewed
Jan 17, 2025
|
|
||
| int sched_getcpucount(void) | ||
| { | ||
| return CONFIG_SMP_NCPUS; |
There was a problem hiding this comment.
What happens if this value is not present?
I think we need to define values for when config is not existing.
There was a problem hiding this comment.
like
#if defined(CONFIG_SMP_NCPUS)
return CONFIG_SMP_NCPUS;
#else
return 0
or
In the file,
#if defined(CONFIG_SMP_NCPUS)
#define NCPUS CONFIG_SMP_NCPUS
#else
#define NCPUS 0
...
in sched_getcpucount()
return NCPUS;
There was a problem hiding this comment.
We are already defining the config if it is not present.
Lines 302 to 304 in e28022b
jeongarmy
reviewed
Jan 17, 2025
| @@ -179,32 +177,24 @@ static void cpuload_print_pid_value(char *buf, void *arg) | |||
| } else { | |||
| #ifdef CONFIG_SCHED_MULTI_CPULOAD | |||
| for (i = PROC_STAT_CPULOAD_SHORT; i <= PROC_STAT_CPULOAD_LONG; i++) { | |||
| #ifdef CONFIG_SMP | |||
| char * avgload[CONFIG_SMP_NCPUS + 1]; | |||
| char * avgload[ncpus + 1]; | |||
There was a problem hiding this comment.
ncpus is not static value. you define array with not defined value.. Is it ok? I think it makes warning or error.
There was a problem hiding this comment.
I think, this also shouldn't create issue as syscall will return a constant value based on CONFIG_SMP_NCPUS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.