-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(docs): update 'configuring' #531
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-keliukh
reviewed
Oct 16, 2020
i-keliukh
reviewed
Oct 16, 2020
i-keliukh
reviewed
Oct 16, 2020
i-keliukh
reviewed
Oct 16, 2020
6a5de62
to
d3bd0c9
Compare
o-andrieiev
previously approved these changes
Oct 16, 2020
Please update the commit description to reflect recent naming changes |
i-keliukh
reviewed
Oct 19, 2020
i-keliukh
reviewed
Oct 21, 2020
i-keliukh
reviewed
Oct 21, 2020
i-keliukh
reviewed
Oct 21, 2020
i-keliukh
reviewed
Oct 21, 2020
i-keliukh
approved these changes
Oct 21, 2020
i-keliukh
reviewed
Feb 10, 2022
As second and third build configurations have the same names, if log files are created, | ||
only two logs will be created: one for the first build step, another for both second and third, | ||
where the third will follow the second. | ||
As second and third steps have the same names, if log files are created, only two logs will be created: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second and third steps have different names.
Either the example or note has to be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual purpose of this change is to differentiate the 'build step',
that is a
Step
instance, from the 'project configuration',that is a
Configuration
instance.