Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docs): update 'configuring' #531

Merged
merged 6 commits into from
Oct 21, 2020
Merged

refactor(docs): update 'configuring' #531

merged 6 commits into from
Oct 21, 2020

Conversation

k-dovgan
Copy link
Contributor

@k-dovgan k-dovgan commented Oct 15, 2020

Actual purpose of this change is to differentiate the 'build step',
that is a Step instance, from the 'project configuration',
that is a Configuration instance.

@k-dovgan
Copy link
Contributor Author

doc/configuring.rst Outdated Show resolved Hide resolved
doc/configuring.rst Outdated Show resolved Hide resolved
doc/configuring.rst Outdated Show resolved Hide resolved
doc/configuring.rst Outdated Show resolved Hide resolved
o-andrieiev
o-andrieiev previously approved these changes Oct 16, 2020
@o-andrieiev
Copy link
Collaborator

Please update the commit description to reflect recent naming changes

setup.py Show resolved Hide resolved
doc/configuring.rst Outdated Show resolved Hide resolved
doc/configuring.rst Outdated Show resolved Hide resolved
doc/configuring.rst Outdated Show resolved Hide resolved
@k-dovgan k-dovgan merged commit 8fe269c into master Oct 21, 2020
@k-dovgan k-dovgan deleted the update-configuring branch October 21, 2020 15:08
As second and third build configurations have the same names, if log files are created,
only two logs will be created: one for the first build step, another for both second and third,
where the third will follow the second.
As second and third steps have the same names, if log files are created, only two logs will be created:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second and third steps have different names.
Either the example or note has to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants