iommufd: remove put_device_fd logic #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An IOAS may have several devices attached, so devfd does not belong as a member within struct iommu_ioas. Remove it. This member was used in put_device_fd, but the iommufd backend does not need such cleanup. It is enough to close the device file descriptor (which we do in vfio_pci_close). Signed-off-by: Klaus Jensen <[email protected]>
birkelund
force-pushed
the
iommufd-remove-put_device_fd
branch
from
c5e1dc4 to
1693cbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An IOAS may have several devices attached, so devfd does not belong as a member within struct iommu_ioas. Remove it.
This member was used in put_device_fd, but the iommufd backend does not need such cleanup. It is enough to close the device file descriptor (which we do in vfio_pci_close).