nvme: add support for CMB (Controller Memory Buffer) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkelund
requested changes
Dec 12, 2024
birkelund
reviewed
Dec 18, 2024
src/nvme/core.c
Outdated
| (ctrl->cmb.iova >> NVME_CMBMSC_CBA_SHIFT) << | ||
| NVME_CMBMSC_CBA_SHIFT; | ||
|
|
||
| mmio_lh_write64(ctrl->regs + NVME_REG_CMBMSC, cpu_to_le64(cmbmsc)); |
There was a problem hiding this comment.
I think this needs to be a mmio_hl_write64 (we want to make sure we write the CBA before setting CMSE).
There was a problem hiding this comment.
Ah, my bad, actually I intended just like you're saying, but reversered ;) Thanks for catching this!
There was a problem hiding this comment.
This is still the low-high variant.
There was a problem hiding this comment.
Missed that one. Applied, Thanks.
birkelund
reviewed
Dec 18, 2024
src/nvme/core.c
Outdated
| cmbloc = le32_to_cpu(mmio_read32(ctrl->regs + NVME_REG_CMBLOC)); | ||
| bar = NVME_FIELD_GET(cmbloc, CMBLOC_BIR); | ||
|
|
||
| cmbmsc = le64_to_cpu(mmio_read64(ctrl->regs + NVME_REG_CMBMSC)); |
There was a problem hiding this comment.
If the register read is required to flush the CRE write, then this should be moved above the read to CMBLOC. And if it is required, a comment staging why would be nice :)
birkelund
reviewed
Dec 18, 2024
Fix sparse error to avoid leint64_t -> integer degradation.
../include/vfn/support/mmio.h:72:52: warning: restricted leint64_t degrades to integer
Signed-off-by: Minwoo Im <[email protected]>
|
All addressed! Thanks, |
CMB provides device memory buffer for driver context such as SQ/CQ and data buffer. nvme_configure_cmb() initializes CMB registers in the nvme controller and nvme_discard_cmb() will disable it and destroy the cmb attributes in @ctrl->cmb. Signed-off-by: Minwoo Im <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMB provides device memory buffer for driver context such as SQ/CQ and data buffer. nvme_configure_cmb() initializes CMB registers in the nvme controller and nvme_discard_cmb() will disable it and destroy the cmb attributes in @ctrl->cmb.