added page View

[zdoryyk]

What type of PR is this? (check all applicable)

• Support for Swipe Navigation in Notes Read-Only Page #217

Description

Added almost all features from issue

Featured Covered in this PR

• Modify NotePreviewCard to accept an index parameter from home screen's Listview.
• Modify NotesReadOnlyPage to accept indexas route parameter and pass index from NotePreviewCard which will serve as initial index for swipe navigation.
• Implement a PageView in NotesReadOnlyPage that allows swiping between notes in read-only mode.
• Ensure that the notes load correctly when swiped left or right.

Related Tickets & Documents

• Support for Swipe Navigation in Notes Read-Only Page #217
• Support for Swipe Navigation in Notes Read-Only Page #217

Screenshots, Recordings

Screen.Recording.2024-10-04.at.13.48.20.mov

Tested Feature??

• In Real Device.
• In Emulator

[zdoryyk]

I should fix that state, But I have no idea how to, can someone help me?

[SankethBK]

Hi, the issue is because you are adding notesBloc.add(InitializeNote(id: noteId); inside itemBuilder, when this happens a new note is fetched and the new note is sent to all the BlocBuilders listening to notesBloc. So as a result both current and next/previous pages are getting updated with same note.

I have added fix in this commit 290b2d090ad4a7a74d031ba027be70a926aa61b3, just cherry-pick this commit to your PR.

As a fix i have added buildWhen to rebuild only if the id matches the id of the note we got from index. This ensures we rebuild only for 1 page.

               buildWhen: (previousState, currentState) {
                    
                          if (currentState.safe) {
                            // Rebuild only if the note in the bloc matches the note ID of this page
                            return currentState.id == _notePreview.id;
                          }
                          return false; 
                        },

I also made some more changes

1. Instead of passing noteIds as route parameter, i am fetching it using BlocProvider.of<NotesFetchCubit>(context);.
2. Instead of passing index in route parameter, i am iterating through the array of notes and checking which id matches the id we got from route param, the advantage of this is we are no longer dependant on id from route param and the solution can also be extended to the case when we open NotesReadOnlyPage from NoteCreatePage.

Currently there is another small bug: When we open NotesReadOnlyPage from NoteCreatePage by clicking on eye button we are not passing note id as a result it assumes id as 0 and goes to first note. We can pass id here also from route param so that it works correctly for this case as well.

[zdoryyk]

ty very much for your response, I got it

[zdoryyk]

@SankethBK Hi again, we have also problem with TAGS, When i trying to add, I have null error operator, how can I fix it?

[SankethBK]

Hi, can you share a screen recording of the issue

[zdoryyk]

Hi, can you share a screen recording of the issue

Look tags

Screen.Recording.2024-10-07.at.09.14.22.mov

[zdoryyk]

Screen.Recording.2024-10-07.at.09.14.22.mov

also this bug, when i trying to add tag

[SankethBK]

Hey, i tried couple of things, i was able to solve the tags issue but ran into some null value issue somewhere. I will try again and update you by tomorrow

[SankethBK]

I'll merge it to master once i fix these issues

[SankethBK]

Hey i have added fixes in this PR
Mainly i had to fix these issues

1. Don't allow swipe navigation if note read page is opened from note create page as the note could've been edited. For this i wam checking if id is null, means the navigation happened from note create page instead of home page in such cases don't render pageview at all.
2. Tags issue is happening its being fetched from BlocBuilder, since notesBloc holds the state of currently active note, tags of that note will be updated. Fix was to pass tags from NoteReadOnlyPage rather than reading from BlocBuilder.

[zdoryyk]

Hello, thanks, I will change it

[SankethBK]

I already added the changes, just letting you know