Fix/save note popup appears unmodified #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Hi, your approach is correct. I slightly refactored your code by extracting common functions into a mixin to keep it more maintainable. Thanks for contributing! |
SankethBK
approved these changes
Oct 7, 2024
|
Thank you for the feedback! I’m happy to see my code being improved. I’ll definitely keep the mixin approach in mind. |
SankethBK
added a commit
that referenced
this pull request
Oct 11, 2024
* Fix Unsaved Changes Detection in Notes: Implement Hash Comparison Logic * Fix Unsaved Changes Detection in Notes: Implement Hash Comparison Logic * refactor common methods with mixin * fix formatting --------- Co-authored-by: Sanketh B K <[email protected]> Co-authored-by: Sanketh B K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This pull request addresses the issue of unsaved changes detection in the note-taking application. The current implementation of the
NotesBlocdoes not adequately track changes made in the rich text editor when the title, createdAt, allNoteAssets, or tags remain unchanged. This results in situations where the user may unknowingly navigate away from the note without receiving a prompt to save changes.Solution
When the user clicks the back button in
note_create_page.dartornote_read_only_page.dart, the note is retrieved from the database, and its hash is compared to the current hash. If the hashes are different, indicating that the note content has changed, a confirmation popup is displayed to the user; otherwise, the screen is popped without interruption.This change modularizes the hash comparison logic, allowing for reuse in multiple pages (
notes_create_page.dartandnote_read_only_page.dart) through thehandleWillPopmethod in the newly createdNoteHelperclass.Featured Covered in this PR
Related Tickets & Documents
Screenshots, Recordings
diaryvault.online-video-cutter.com.mp4
Tested Feature??