RHEL10 Clients coverage, rhel7 & 8 hosts bumped #17003

damoore044 · 2024-11-26T22:14:48Z

Update RH repos for RHEL10 Beta, BaseOS, and Appstream
Migrate existing rhel 7 and 8 content hosts to rhel 9 and 10.
By parametrization of host fixtures listed here: /pytest_plugins/fixture_markers.py
or by importing the newly added fixtures rhel10_contenthost , rhel10_contenthost_module

Fore Reviewers: Many clients are still using RHEL8, and their BZ coverage relies on some RedHat packages, errata, content etc, that is not yet available for RHEL10. Should we bump these 8 clients to RHEL9, until the needed content is available for RHEL10?

PRT

For cases using fixture rhel_contenthost
parametrized by pytest.marker.rhel_ver_match or rhel_ver_list

trigger: test-robottelo
pytest: tests/foreman/api cli ui/module.py -k 'rhel10'

damoore044 · 2024-11-26T22:28:37Z

trigger: test-robottelo
pytest: tests/foreman/ -k 'rhel10' --ignore-glob='**/test_errata.py' --collect-only

damoore044 · 2024-11-26T22:29:55Z

^ ignoring errata rhel10 cases for first collection,
as they've already been tested and merged in #16807

Works locally but fails for PRT, see below for proper CI exclusion comment

17:46:48  ============================= test session starts ==============================
17:46:48  platform linux -- Python 3.12.7, pytest-8.3.3, pluggy-1.5.0
    ...
17:47:20  collected 5460 items / 5412 deselected / 48 selected <<<

damoore044 · 2024-11-26T22:37:55Z

trigger: test-robottelo
pytest: tests/foreman/ -k 'rhel10' --collect-only $(find tests/foreman/ -type f -name 'test_errata.py' -exec echo --ignore={} \;)

damoore044 · 2024-11-26T22:53:31Z

trigger: test-robottelo
pytest: tests/foreman/api/ -k 'rhel10' $(find tests/foreman/ -type f -name 'test_errata.py' -exec echo --ignore={} \;)
env:
     ROBOTTELO_content_host__rhel10__vm__workflow: 'deploy-template'
     ROBOTTELO_content_host__rhel10__vm__deploy_template_type: 'rhel'
     ROBOTTELO_content_host__rhel10__vm__deploy_custom_template_version: '10'

damoore044 · 2024-11-26T22:54:32Z

^ foreman/API tests with rhel10 params, ignoring test_errata.py
Should be 9 new cases (rhel10) collected and executed

damoore044 · 2024-11-26T22:59:22Z

trigger: test-robottelo
pytest: tests/foreman/api/ -k 'rhel10' $(find tests/foreman/api/ -type f -name 'test_errata.py' -exec echo --ignore={} \;)
env:
     ROBOTTELO_content_host__rhel10__vm__workflow: 'deploy-template'
     ROBOTTELO_content_host__rhel10__vm__deploy_template_type: 'rhel'
     ROBOTTELO_content_host__rhel10__vm__deploy_custom_template_version: '10'

damoore044 · 2024-11-27T13:00:00Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py -k 'rhel10' 
env:
     ROBOTTELO_content_host__rhel10__vm__workflow: 'deploy-template'
     ROBOTTELO_content_host__rhel10__vm__deploy_template_type: 'rhel'
     ROBOTTELO_content_host__rhel10__vm__deploy_custom_template_version: '10'

Satellite-QE · 2024-11-27T14:53:00Z

PRT Result

Build Number: 9471
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contenthost.py -k rhel10 --external-logging
Test Result : == 10 failed, 10 passed, 129 deselected, 1457 warnings in 6396.11s (1:46:36) ===

damoore044 · 2024-11-29T15:37:05Z

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py
env:
     ROBOTTELO_content_host__rhel10__vm__workflow: 'deploy-template'
     ROBOTTELO_content_host__rhel10__vm__deploy_template_type: 'rhel'
     ROBOTTELO_content_host__rhel10__vm__deploy_custom_template_version: '10'

damoore044 · 2024-11-29T15:38:33Z

^ Full test of all cases api/test_errata.py , rhel10 and priors.
Due to significant changes to that module

damoore044 · 2024-11-29T17:44:55Z

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py

Satellite-QE · 2024-11-29T20:49:50Z

PRT Result

Build Number: 9490
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_errata.py --external-logging
Test Result : ========== 4 failed, 10 passed, 4437 warnings in 10620.88s (2:57:00) ===========

damoore044 · 2024-12-07T13:29:26Z

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py

Satellite-QE · 2024-12-07T15:30:32Z

PRT Result

Build Number: 9554
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_errata.py --external-logging
Test Result : =========== 7 failed, 1279 warnings, 7 errors in 6489.17s (1:48:09) ============

damoore044 · 2024-12-17T16:37:46Z

trigger: test-robottelo
pytest: tests/foreman/api -k 'rhel10'

damoore044 · 2024-12-17T16:37:57Z

trigger: test-robottelo
pytest: tests/foreman/cli -k 'rhel10'

Satellite-QE · 2024-12-17T21:17:36Z

PRT Result

Build Number: 9659
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli -k rhel10 --external-logging
Test Result : = 9 failed, 12 passed, 1938 deselected, 5353 warnings, 14 errors in 16245.78s (4:30:45) =

damoore044 · 2025-01-08T18:18:41Z

trigger: test-robottelo
pytest: tests/foreman/api -k 'rhel10'

pytest_fixtures/component/provisioning_template.py

damoore044 · 2025-01-15T19:06:56Z

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py::TestProvisioningTemplate::test_positive_template_check_rex_snippet[rhel10-ipv4]

damoore044 · 2025-01-15T19:11:16Z

pre-commit.ci autofix

Satellite-QE · 2025-01-15T19:23:37Z

PRT Result

Build Number: 9892
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_provisioningtemplate.py::TestProvisioningTemplate::test_positive_template_check_rex_snippet[rhel10-ipv4] --external-logging
Test Result : ================== 1 passed, 9 warnings in 689.56s (0:11:29) ===================

damoore044 · 2025-01-16T17:28:07Z

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py::TestAnsibleREX::test_positive_ansible_job_on_multiple_host

Satellite-QE · 2025-01-16T18:18:16Z

PRT Result

Build Number: 9907
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_ansible.py::TestAnsibleREX::test_positive_ansible_job_on_multiple_host --external-logging
Test Result : ================= 1 failed, 25 warnings in 2429.79s (0:40:29) ==================

damoore044 · 2025-01-17T16:52:12Z

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py::TestAnsibleREX::test_positive_ansible_job_on_multiple_host

Satellite-QE · 2025-01-17T17:44:40Z

PRT Result

Build Number: 9926
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_ansible.py::TestAnsibleREX::test_positive_ansible_job_on_multiple_host --external-logging
Test Result : ================= 1 failed, 25 warnings in 2529.99s (0:42:09) ==================

damoore044 · 2025-01-22T17:45:03Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'rhel10'

damoore044 · 2025-01-22T17:51:06Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_http_proxy.py -k 'rhel10'

Satellite-QE · 2025-01-22T18:20:44Z

PRT Result

Build Number: 9959
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_http_proxy.py -k rhel10 --external-logging
Test Result : ========== 2 passed, 9 deselected, 132 warnings in 1379.42s (0:22:59) ==========

Satellite-QE · 2025-01-22T18:47:19Z

PRT Result

Build Number: 9958
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k rhel10 --external-logging
Test Result : ==== 1 passed, 96 deselected, 697 warnings, 6 errors in 3287.36s (0:54:47) =====

vsedmik

Overall looks good to me, I've only put a couple of nits below to address.

Somewhat bigger question is the usage of rhelX_contenthost. There was a discussion at the JPL call this week about moving away from them to rhel_contenthost + param (to resolve the IPv6 hosts deploy issue). @JacobCallahan said he would raise a PR for that, which would cause a merge conflict for one of you.

I'd propose both of you to negotiate on the next steps so you don't double the work. Anyway we might like to avoid the rhelX_contenthosts in this PR to minimize the conflict.

vsedmik · 2025-01-24T09:14:20Z

tests/foreman/ui/test_contenthost.py

@@ -908,11 +886,10 @@ def test_module_stream_actions_on_content_host(
    'module_repos_collection_with_manifest',
    [
        {
-            'distro': 'rhel8',
+            'distro': 'rhel10',


Suggested change

'distro': 'rhel10',

'distro': CHOST_RHEL_VER,

vsedmik · 2025-01-24T09:14:34Z

tests/foreman/ui/test_contenthost.py

@@ -973,11 +950,10 @@ def test_module_streams_customize_action(session, default_location, vm_module_st
    'module_repos_collection_with_manifest',
    [
        {
-            'distro': 'rhel8',
+            'distro': 'rhel10',


Suggested change

'distro': 'rhel10',

'distro': CHOST_RHEL_VER,

vsedmik · 2025-01-24T09:14:53Z

tests/foreman/ui/test_contenthost.py

@@ -1050,11 +1026,10 @@ def test_install_modular_errata(session, default_location, vm_module_streams):
    'module_repos_collection_with_manifest',
    [
        {
-            'distro': 'rhel8',
+            'distro': 'rhel10',


Suggested change

'distro': 'rhel10',

'distro': CHOST_RHEL_VER,

vsedmik · 2025-01-24T09:17:00Z

tests/foreman/ui/test_contenthost.py

@@ -1439,6 +1412,7 @@ def test_syspurpose_bulk_action(session, default_location, vm):
        session.location.select(default_location.name)
        session.contenthost.bulk_set_syspurpose([vm.hostname], syspurpose_attributes)
        details = session.contenthost.read(vm.hostname, widget_names='details')['details']
+        result = vm.execute('subscription-manager repos')


Looks like a forgotten debug line. Do we need it?

vsedmik · 2025-01-24T09:30:38Z

tests/foreman/api/test_errata.py

+    '''chost.run(f'yum install -y {REAL_RHEL8_1_PACKAGE_FILENAME}')
    erratum = _fetch_available_errata(host, 2)
    assert len(erratum) == 2
-    assert REAL_RHEL8_1_ERRATA_ID in [errata['errata_id'] for errata in erratum]
+    assert REAL_RHEL8_1_ERRATA_ID in [errata['errata_id'] for errata in erratum]'''


Was this "stringed out" intentionally?
I'd rather use # if you aimed to remark it out, or remove completely.

damoore044 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Nov 26, 2024

damoore044 self-assigned this Nov 26, 2024

damoore044 force-pushed the rhel10-cases branch from 829ef70 to a008694 Compare November 26, 2024 23:25

damoore044 changed the title ~~RHEL10 Clients coverage in Content, some rhel8 content bumped to rhel9~~ RHEL10 Clients coverage in Content, some rhel7 and 8 content bumped to rhel9 and 10 Nov 26, 2024

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Nov 27, 2024

damoore044 force-pushed the rhel10-cases branch from a008694 to 2b76a7f Compare November 29, 2024 15:36

damoore044 force-pushed the rhel10-cases branch from 2b76a7f to 595f819 Compare November 29, 2024 17:41

damoore044 force-pushed the rhel10-cases branch from 595f819 to d26d767 Compare December 7, 2024 13:28

damoore044 force-pushed the rhel10-cases branch 2 times, most recently from a16ae35 to 448d830 Compare December 17, 2024 16:36

damoore044 force-pushed the rhel10-cases branch from 448d830 to 3850055 Compare January 8, 2025 18:15

lhellebr reviewed Jan 15, 2025

View reviewed changes

pytest_fixtures/component/provisioning_template.py Outdated Show resolved Hide resolved

damoore044 force-pushed the rhel10-cases branch from 77ecb95 to 73a09d7 Compare January 15, 2025 19:02

damoore044 force-pushed the rhel10-cases branch from 2c36c06 to 8740193 Compare January 15, 2025 19:18

Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jan 15, 2025

damoore044 force-pushed the rhel10-cases branch from 8740193 to ecaec78 Compare January 16, 2025 16:54

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 16, 2025

damoore044 force-pushed the rhel10-cases branch from ecaec78 to a84e060 Compare January 16, 2025 17:03

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jan 16, 2025

damoore044 force-pushed the rhel10-cases branch from a84e060 to 6c37fb3 Compare January 17, 2025 16:51

damoore044 added 3 commits January 22, 2025 12:33

rhel10 parametrized fixture chosts

aec9ae8

rhel10_bos_beta for fixture module_sync_kickstart_content

505b95c

api fixes

45c606e

damoore044 force-pushed the rhel10-cases branch from 6c37fb3 to 45c606e Compare January 22, 2025 17:33

Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jan 22, 2025

Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Jan 22, 2025

vsedmik requested changes Jan 24, 2025

View reviewed changes

RHEL10 Clients coverage, rhel7 & 8 hosts bumped #17003

Are you sure you want to change the base?

RHEL10 Clients coverage, rhel7 & 8 hosts bumped #17003

Conversation

damoore044 commented Nov 26, 2024 • edited Loading

PRT

damoore044 commented Nov 26, 2024

damoore044 commented Nov 26, 2024 • edited Loading

damoore044 commented Nov 26, 2024

damoore044 commented Nov 26, 2024

damoore044 commented Nov 26, 2024 • edited Loading

damoore044 commented Nov 26, 2024

damoore044 commented Nov 27, 2024

Satellite-QE commented Nov 27, 2024

damoore044 commented Nov 29, 2024

damoore044 commented Nov 29, 2024

damoore044 commented Nov 29, 2024

Satellite-QE commented Nov 29, 2024

damoore044 commented Dec 7, 2024

Satellite-QE commented Dec 7, 2024

damoore044 commented Dec 17, 2024

damoore044 commented Dec 17, 2024

Satellite-QE commented Dec 17, 2024

damoore044 commented Jan 8, 2025

damoore044 commented Jan 15, 2025

damoore044 commented Jan 15, 2025

Satellite-QE commented Jan 15, 2025

damoore044 commented Jan 16, 2025

Satellite-QE commented Jan 16, 2025

damoore044 commented Jan 17, 2025

Satellite-QE commented Jan 17, 2025

damoore044 commented Jan 22, 2025

damoore044 commented Jan 22, 2025

Satellite-QE commented Jan 22, 2025

Satellite-QE commented Jan 22, 2025

vsedmik left a comment

Choose a reason for hiding this comment

vsedmik Jan 24, 2025

Choose a reason for hiding this comment

vsedmik Jan 24, 2025

Choose a reason for hiding this comment

vsedmik Jan 24, 2025

Choose a reason for hiding this comment

vsedmik Jan 24, 2025

Choose a reason for hiding this comment

vsedmik Jan 24, 2025

Choose a reason for hiding this comment

damoore044 commented Nov 26, 2024 •

edited

Loading

damoore044 commented Nov 26, 2024 •

edited

Loading

damoore044 commented Nov 26, 2024 •

edited

Loading