Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

negative assertions for rex effective user tests #17348

Merged
merged 1 commit into from
Jan 22, 2025
Merged

negative assertions for rex effective user tests #17348

merged 1 commit into from
Jan 22, 2025

Conversation

pondrejk
Copy link
Contributor

Problem Statement

Adding some negative assertions for rex effective user tests on ssh and pull provider

Solution

Related Issues

@pondrejk pondrejk added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.16.z Introduced in or relating directly to Satellite 6.16 labels Jan 16, 2025
@pondrejk pondrejk self-assigned this Jan 16, 2025
@pondrejk pondrejk requested a review from a team as a code owner January 16, 2025 16:35
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k test_positive_run_job_effective_user[rhel9-ipv4-sudo]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9904
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k test_positive_run_job_effective_user[rhel9-ipv4-sudo] --external-logging
Test Result : ========== 1 passed, 69 deselected, 82 warnings in 1374.45s (0:22:54) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 16, 2025
@lhellebr
Copy link
Contributor

Should these really be part of the existing tests? How about making new negative tests? Especially since there's no heavy setup.

@pondrejk
Copy link
Contributor Author

@lhellebr both options have pros and cons, here I lean towards extending the existing tests to make use of the parametrization to get this tested across rhel versions. With separate tests I'd have to create those clients again

@sambible sambible merged commit 0ac33fa into SatelliteQE:master Jan 22, 2025
13 checks passed
@Satellite-QE Satellite-QE mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhellebr lhellebr lhellebr approved these changes

@sambible sambible sambible approved these changes

Assignees

@pondrejk pondrejk

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pondrejk @Satellite-QE @lhellebr @sambible