fixed subscription list test case

[vijaysawant]

Problem Statement

Test case test_positive_access_with_non_admin_user_with_manifest was failing due to Error
TypeError: 'NoneType' object is not subscriptable

Solution

Collect the list of all available scriptions from the page and iterate over each till matches default subscription name

Airgun PR

SatelliteQE/airgun#1702

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_access_with_non_admin_user_with_manifest'
airgun: 1702

[vijaysawant]

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_access_with_non_admin_user_with_manifest'
airgun: 1702

[Satellite-QE]

PRT Result

Build Number: 9934
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_access_with_non_admin_user_with_manifest --external-logging
Test Result : =========== 1 passed, 7 deselected, 16 warnings in 721.34s (0:12:01) ===========

[vsedmik]

One proposal and question

[vsedmik]

This should do the same I think (haven't tried locally though)

Suggested change

	for subscription in all_subscriptions:
	if subscription['Name'] == DEFAULT_SUBSCRIPTION_NAME:
	assert True
	break
	else:
	pytest.fail(f"{DEFAULT_SUBSCRIPTION_NAME} not found..!")
	assert any(sub['Name'] == DEFAULT_SUBSCRIPTION_NAME for sub in all_subscriptions)

Btw, why didn't the original search work? I'm guessing it should return just one result (if the subscription is present).

[vijaysawant]

Original search doesn't work, I changed UI selector and tried, but again when we are on page, view not able to click on Search button.

[sambible]

These test changes shouldn't be necessary with the proper airgun fixes I've suggested.

[vijaysawant]

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_access_with_non_admin_user_with_manifest'
airgun: 1702

[Satellite-QE]

PRT Result

Build Number: 9944
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_access_with_non_admin_user_with_manifest --external-logging
Test Result : ========== 1 passed, 7 deselected, 18 warnings in 1762.06s (0:29:22) ===========

[vijaysawant]

These changes are no longer needed, as per @sambible suggestion making changes in airgun view of subscription SatelliteQE/airgun#1702 and changes are working absolutely fine.
So closing this PR.

[vijaysawant]

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_access_with_non_admin_user_with_manifest'
airgun: 1702

[vijaysawant]

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_access_with_non_admin_user_with_manifest'
airgun: 1702

[Satellite-QE]

PRT Result

Build Number: 9950
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_access_with_non_admin_user_with_manifest --external-logging
Test Result : =========== 1 failed, 7 deselected, 16 warnings in 647.00s (0:10:47) ===========

[vijaysawant]

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_access_with_non_admin_user_with_manifest'
airgun: 1702

[Satellite-QE]

PRT Result

Build Number: 9951
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_access_with_non_admin_user_with_manifest --external-logging
Test Result : =========== 1 failed, 7 deselected, 16 warnings in 671.70s (0:11:11) ===========