Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the fixture for rhel_ver to correctly fetch the appropriate kickstart repository #17385

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Updated the fixture for rhel_ver to correctly fetch the appropriate kickstart repository #17385

merged 1 commit into from
Jan 30, 2025

Conversation

amolpati30
Copy link
Contributor

The support for rhel10_bos_beta was not added, which caused the test to fail. Update the code to include a condition in the if statement that handles rhel10_bos_beta, ensuring the data is fetched correctly for rhel10 so the test can run successfully.

@amolpati30 amolpati30 added Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jan 20, 2025
@amolpati30 amolpati30 requested a review from a team as a code owner January 20, 2025 12:34
@amolpati30 amolpati30 force-pushed the update_condition_for_rhel_ver branch from 7d28ac0 to 38fd1c3 Compare January 20, 2025 12:36
@amolpati30 amolpati30 requested a review from ekohl January 20, 2025 12:56
@amolpati30 amolpati30 changed the title updated the fixture for rhel_ver from 8 to 10 Updated the fixture for rhel_ver to correctly fetch the appropriate kickstart repository Jan 20, 2025
@amolpati30 amolpati30 force-pushed the update_condition_for_rhel_ver branch from 38fd1c3 to 1f779b0 Compare January 20, 2025 13:06
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9937
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_provisioningtemplate.py::TestProvisioningTemplate -k test_positive_template_check_ipxe --external-logging
Test Result : ========== 4 passed, 32 deselected, 155 warnings in 860.35s (0:14:20) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 20, 2025
@amolpati30 amolpati30 force-pushed the update_condition_for_rhel_ver branch from 1f779b0 to af055dc Compare January 28, 2025 14:31
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 28, 2025
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py::TestProvisioningTemplate -k test_positive_template_check_ipxe

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10001
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_provisioningtemplate.py::TestProvisioningTemplate -k test_positive_template_check_ipxe --external-logging
Test Result : ========== 4 passed, 32 deselected, 153 warnings in 823.39s (0:13:43) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 28, 2025
@Gauravtalreja1 Gauravtalreja1 merged commit 1bef83a into SatelliteQE:master Jan 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@ekohl ekohl Awaiting requested review from ekohl

Assignees

@amolpati30 amolpati30

Labels
Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amolpati30 @Satellite-QE @ekohl @Gauravtalreja1