Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search functionality to home screen #241

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Add search functionality to home screen #241

merged 1 commit into from
Jul 20, 2020

Conversation

Kilo-Loco
Copy link
Member

@Kilo-Loco Kilo-Loco commented Jul 20, 2020 •
edited
Loading

Added the ability to search for a person by name from the home screen.

Address issue 235

Search screen presenting George results

@Kilo-Loco Kilo-Loco added the review me This PR needs more reviewers label Jul 20, 2020
@ohwhen ohwhen self-requested a review July 20, 2020 19:37
ohwhen
ohwhen approved these changes Jul 20, 2020
View reviewed changes
Copy link
Collaborator

@ohwhen ohwhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

tomacotuna
tomacotuna approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@tomacotuna tomacotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Kilo-Loco Kilo-Loco merged commit 057a3d2 into development Jul 20, 2020
@Kilo-Loco Kilo-Loco deleted the feature/search branch July 20, 2020 23:24
@Kilo-Loco Kilo-Loco mentioned this pull request Jul 20, 2020
Closed
hybridcattt added a commit that referenced this pull request Oct 7, 2020
@hybridcattt
Merge branch 'release/1.1'
9c80fab 
* release/1.1:
  Try to always run build CI job
  Bumped version to 1.1 (6)
  [CHORE] Update slack-community link
  [FIX] Empty home on slow connection (#252)
  [FIX] Search results UI (#249)
  [FIX] Update slack contribution URL (#253)
  Making sure names fit on home for most text sizes (#251)
  #240 (#245)
  [FIX] Add missing accessibility in carousel collection view cells (#247)
  Changed Placeholder to black fists (#246)
  [FIX] Fix PersonCell image contraints (#244)
  [FIX] Fix HeroTextCell showing person details when selected (#242)
  Add search functionality to home screen (#241)
  Merging master -> development (#226)
  Update CONTRIBUTING.md (#233)
  [Chore] Added accessibility Identifier to MainTabBarController (#223)
  [CHORE] Gather SDWebImage usage under ImageService + dependency inject it (#222)
  [CHORE] Remove unused code  (#221)
  [UI] BackgroundColor to resolve to SystemBackground, update usages for consistency. (#220)
  [CHORE] Adding Spanish as a locale (#219)

# Conflicts:
#	SayTheirNames.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohwhen ohwhen ohwhen approved these changes

@tomacotuna tomacotuna tomacotuna approved these changes

Assignees
No one assigned
Labels
review me This PR needs more reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kilo-Loco @ohwhen @tomacotuna