Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PINNOptimizers Benchmarks #1148

Merged
merged 8 commits into from
Jan 20, 2025
Merged

Conversation

ParamThakkar123
Copy link
Contributor

@ParamThakkar123 ParamThakkar123 commented Jan 1, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas I fixed the PINNOptimizers benchmarks and it was running well locally but the tests seem to be running for 18 hours now.

@ChrisRackauckas
Copy link
Member

Like the other, force the latest versions and make sure the manifest resolves

@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas I have updated the PINNOptimizers benchmarks, resolved manifest and tested it locally. Everything works fine and gives the correct results

@ParamThakkar123
Copy link
Contributor Author

I think this got stuck at line 140 and isn't progressing further

@ChrisRackauckas
Copy link
Member

Where exactly are you stuck? What's the code and what's the error?

@ParamThakkar123
Copy link
Contributor Author

No. I wasn't stuck at any point, but the CI took a lot of time to complete like 41 hours. and yesterday it was stuck on processing line number 140 the whole day

@ParamThakkar123
Copy link
Contributor Author

The CI is complete and the code outputs the results with no errors

@ParamThakkar123
Copy link
Contributor Author

Manifest resolved too

@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas This is done. Can you please review this ?? I will work on fixing the other two of my remaining PRs won't take much time

@ChrisRackauckas
Copy link
Member

Yes looks good now!

@ChrisRackauckas ChrisRackauckas merged commit b8bcd8a into SciML:master Jan 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants