-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PINNOptimizers Benchmarks #1148
Conversation
@ChrisRackauckas I fixed the PINNOptimizers benchmarks and it was running well locally but the tests seem to be running for 18 hours now. |
Like the other, force the latest versions and make sure the manifest resolves |
@ChrisRackauckas I have updated the PINNOptimizers benchmarks, resolved manifest and tested it locally. Everything works fine and gives the correct results |
I think this got stuck at line 140 and isn't progressing further |
Where exactly are you stuck? What's the code and what's the error? |
No. I wasn't stuck at any point, but the CI took a lot of time to complete like 41 hours. and yesterday it was stuck on processing line number 140 the whole day |
The CI is complete and the code outputs the results with no errors |
Manifest resolved too |
@ChrisRackauckas This is done. Can you please review this ?? I will work on fixing the other two of my remaining PRs won't take much time |
Yes looks good now! |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.