fix KLU and sparse matrix support

SciML · Apr 5, 2020 · 6643177 · 6643177
1 parent 81e7955
commit 6643177
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/types_and_consts_additions.jl b/src/types_and_consts_additions.jl
@@ -43,6 +43,7 @@ function Base.convert(::Type{SparseArrays.SparseMatrixCSC}, J::SUNMatrix)
     # TODO: Get rid of allocation for 1-based index change
     rowval = unsafe_wrap(Array, mat.indexvals, (mat.NNZ), own=false)
     colptr = unsafe_wrap(Array, mat.indexptrs, (mat.NP+1), own=false)
+    colptr .+= 1
     m = mat.M
     n = mat.N
     nzval = unsafe_wrap(Array,mat.data, (mat.NNZ), own=false)

diff --git a/test/common_interface/jacobians.jl b/test/common_interface/jacobians.jl
@@ -28,8 +28,9 @@ Lotka_f = ODEFunction(Lotka,jac=Lotka_jac,
 
 prob = ODEProblem(Lotka_f,ones(2),(0.0,10.0))
 jac_called = false
-@test_broken sol9 = solve(prob,CVODE_BDF(linear_solver=:KLU))
-@test_broken jac_called == true
+sol9 = solve(prob,CVODE_BDF(linear_solver=:KLU))
+@test jac_called == true
+@test Array(sol9) ≈ Array(good_sol)
 
 Lotka_fj = ODEFunction(Lotka,
                       jac_prototype = JacVecOperator{Float64}(Lotka,ones(2)))