Bind `items` for sets, fix ref issue for `filter` with constant columns #42

Vindaar · 2022-09-28T08:12:03Z

Two minor fixes:

* v0.3.5
- fix reference semantics bugs for constant columns for =filter= calls
- fix issue with =gather= in files that do not import =sets= by
  binding the =items= iterator in the scope

The latter fixes the issue raised in SciNim/getting-started#49 and SciNim/getting-started#50.

Otherwise we get an overload resolution issue in the calling scope, because `items` for `HashSet` won't be defined.

pietroppeter · 2022-09-28T08:17:03Z

TIL about this usage of bind: bind sets.items! nice!

Vindaar added 3 commits September 4, 2022 21:02

fix reference semantics bug in filter call for Columns

5ea62f7

bind items iterator for sets in gather

c9ae68b

Otherwise we get an overload resolution issue in the calling scope, because `items` for `HashSet` won't be defined.

update changelog, push version v0.3.5

c403d83

Vindaar merged commit e711415 into master Sep 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bind `items` for sets, fix ref issue for `filter` with constant columns #42

Bind `items` for sets, fix ref issue for `filter` with constant columns #42

Vindaar commented Sep 28, 2022

pietroppeter commented Sep 28, 2022

Bind items for sets, fix ref issue for filter with constant columns #42

Bind items for sets, fix ref issue for filter with constant columns #42

Conversation

Vindaar commented Sep 28, 2022

pietroppeter commented Sep 28, 2022

Bind `items` for sets, fix ref issue for `filter` with constant columns #42

Bind `items` for sets, fix ref issue for `filter` with constant columns #42