Less repetition in schemes testing
#269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 98.79% 98.67% -0.13%
==========================================
Files 33 34 +1
Lines 3563 3236 -327
==========================================
- Hits 3520 3193 -327
Misses 43 43
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| extract_weights(grid_to_grid), extract_weights(regridder) | ||
| ) | ||
|
|
||
| def test_curvilinear_and_rectilinear(self): |
There was a problem hiding this comment.
Note that this test diverges in behaviour with #276 due to differing behavour of regridders with respect to bounds.
| with pytest.raises(ValueError, match=match): | ||
| _ = self.REGRIDDER(src, tgt, mdtol=-1) | ||
|
|
||
| def test_curvilinear_equivalence(self): |
There was a problem hiding this comment.
Note that this test diverges in behaviour with #276 due to differing behavour of regridders with respect to bounds.
|
@SciTools-incubator/esmf-regrid-devs This pull-request is stale due to a lack of activity in the last 90 days. Remove stale label or comment, otherwise this pull-request will close automatically in 7 days time. |
github-actions
bot
added
the
Stale: Closure warning
trexfeathers
removed
the
Stale: Closure warning
|
Closing due to lack of interest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow on from #266, implementing improved test abstraction.
We have made a good start at reducing duplication in iris-esmf-regrid, but the remaining duplication still makes reviews very difficult. So I felt it important to demonstrate how improvements could be made where similar testing is desired against different elements of the code.