-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI commands for sequester and realm export #9343
Open
touilleMan
wants to merge
3
commits into
sequester-export-memory-only
Choose a base branch
from
cli-sequester-and-realm-export
base: sequester-export-memory-only
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CLI commands for sequester and realm export #9343
touilleMan
wants to merge
3
commits into
sequester-export-memory-only
from
cli-sequester-and-realm-export
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touilleMan
force-pushed
the
cli-sequester-and-realm-export
branch
from
January 14, 2025 11:26
1a5b2ad
to
67a3aae
Compare
FirelightFlagboy
changed the base branch from
master
to
sequester-export-memory-only
January 14, 2025 13:03
I've changed the base so it's "simpler" to review |
touilleMan
force-pushed
the
sequester-export-memory-only
branch
from
January 14, 2025 16:09
ec6ceb2
to
e5ea163
Compare
touilleMan
force-pushed
the
cli-sequester-and-realm-export
branch
2 times, most recently
from
January 14, 2025 16:16
01cb078
to
fd09197
Compare
touilleMan
force-pushed
the
sequester-export-memory-only
branch
from
January 14, 2025 20:51
e5ea163
to
7d741e5
Compare
touilleMan
force-pushed
the
cli-sequester-and-realm-export
branch
from
January 14, 2025 20:52
fd09197
to
67fd373
Compare
vxgmichel
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
logger.info("Backend configuration", **config.logging_kwargs()) | ||
if verbose: | ||
logger.info("Parsec version", version=server_version) | ||
logger.info("Backend configuration", **config.logging_kwargs()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird to conditionally enable logs instead of using a filtering rule.
8 tasks
touilleMan
force-pushed
the
sequester-export-memory-only
branch
from
January 21, 2025 19:33
8479d36
to
519499b
Compare
…g output when used in short-lived CLI commands)
touilleMan
force-pushed
the
cli-sequester-and-realm-export
branch
from
January 21, 2025 19:35
67fd373
to
74b4178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends #9342