Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MS] Adds download file feature in web mode #9398

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[MS] Adds download file feature in web mode #9398

merged 1 commit into from
Jan 23, 2025
+164 −21

Conversation

Max-7
Copy link
Contributor

@Max-7 Max-7 commented Jan 21, 2025

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR

@Max-7 Max-7 requested a review from a team as a code owner January 21, 2025 14:59
@Max-7 Max-7 force-pushed the ms-download-file branch 2 times, most recently from 45d1a7c to bdc48e4 Compare January 22, 2025 14:19
@NicoTuxx
Copy link
Contributor

LGTM for now, but:

  • on chromium based browsers (Edge, Chrome, Arc Browser...) the download is working, but never shown by the UI and not added to the DL history
  • the DLs should be added to the fileOperationsMenu like classic drive apps (Drive, Dropbox...)

@Max-7
Copy link
Contributor Author

Max-7 commented Jan 22, 2025

LGTM for now, but:

  • on chromium based browsers (Edge, Chrome, Arc Browser...) the download is working, but never shown by the UI and not added to the DL history
  • the DLs should be added to the fileOperationsMenu like classic drive apps (Drive, Dropbox...)

#9409

@Max-7 Max-7 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit 55b75a1 Jan 23, 2025
13 checks passed
@Max-7 Max-7 deleted the ms-download-file branch January 23, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoTuxx NicoTuxx NicoTuxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Max-7 @NicoTuxx