Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the ctime of files set to the created time instead of the updated time. #9399

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix the ctime of files set to the created time instead of the updated time. #9399

merged 1 commit into from
Jan 24, 2025

Conversation

FirelightFlagboy
Copy link
Contributor

Closes #8942

@FirelightFlagboy FirelightFlagboy requested a review from a team as a code owner January 21, 2025 16:12
@FirelightFlagboy FirelightFlagboy linked an issue Jan 21, 2025 that may be closed by this pull request
Wrong ctime timestamp on Linux/macOS #8942
Closed
Base automatically changed from acknowledges/3.2.4 to master January 21, 2025 17:24
@github-actions github-actions bot requested review from a team as code owners January 21, 2025 17:24
@vxgmichel
Copy link
Contributor

This PR seems to also contains two unrelated commits, I guess it should be rebased now that #9397 is merged

mmmarcos
mmmarcos approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@mmmarcos mmmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a suggestion on the news fragment

newsfragments/8942.bugfix.rst Outdated Show resolved Hide resolved
@FirelightFlagboy @mmmarcos
Fix #8942: Fix the ctime of files set to the created time instead…
b083f5e 
… of the `updated` time.

Co-authored-by: Marcos Medrano <[email protected]>
@FirelightFlagboy FirelightFlagboy added this pull request to the merge queue Jan 24, 2025
Merged via the queue into master with commit abce6ef Jan 24, 2025
14 checks passed
@FirelightFlagboy FirelightFlagboy deleted the 8942-fix-ctime-value branch January 24, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmmarcos mmmarcos mmmarcos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong ctime timestamp on Linux/macOS
3 participants
@FirelightFlagboy @vxgmichel @mmmarcos